fix: button ripple radius #3388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @dakshbhardwaj, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
Member
|
Thanks @dakshbhardwaj for fixing the bug! 👏🏽 |
lukewalczak
approved these changes
Sep 28, 2022
lukewalczak
pushed a commit
that referenced
this pull request
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix: #3387
In the case when the
borderRadiuswas0the condition was treating it as a falsy value.Replaced it with a check of
Nullish coalescing operatorso that it check only for null and undefined valuesTest plan
Checked manually by applying a style with borderRadius : 0 in the button component