fix: align card actions to the left #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gawrysiak, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
satya164
requested changes
Mar 3, 2018
src/components/Card/CardActions.js
Outdated
| }, | ||
| }); | ||
| render() { | ||
| const styles = StyleSheet.create({ |
There was a problem hiding this comment.
Don't create stylesheets in render, move it to outside. Use inline styles for styles based on props.
src/components/Card/CardActions.js
Outdated
| /** | ||
| * Should actions be aligned to the right. | ||
| */ | ||
| right?: boolean, |
There was a problem hiding this comment.
I don't think we want to provide a prop which doesn't align with material design guidelines. Let's align them to left by default and remove this prop.
eriveltonelias
pushed a commit
to eriveltonelias/react-native-paper
that referenced
this pull request
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggestion to change the CardActions align from right to left. Additionally, it adds a "right" prop to easily go back to the original behavior, without changing any CSS.
Motivation
It seems like the original Material Design guidelines aligns the actions to the left by default. This is as well the standard behavior for other libs, like material-ui.