fix: delay portal rendering to avoid infinite loop

Author: satya164

package.json

@@ -81,6 +81,7 @@
     "react": "16.6.0-alpha.8af6728",
     "react-dom": "16.6.0-alpha.8af6728",
     "react-native": "~0.57.4",
+    "react-native-testing-library": "^1.5.0",
     "react-native-vector-icons": "~6.0.2",
     "react-test-renderer": "16.6.0-alpha.8af6728",
     "release-it": "^7.6.2",

src/components/Portal/PortalConsumer.js

@@ -10,7 +10,7 @@ type Props = {|
 |};
 
 export default class PortalConsumer extends React.Component<Props> {
-  componentDidMount() {
+  async componentDidMount() {
     if (!this.props.manager) {
       throw new Error(
         'Looks like you forgot to wrap your root component with `Provider` component from `react-native-paper`.\n\n' +
@@ -19,6 +19,9 @@ export default class PortalConsumer extends React.Component<Props> {
       );
     }
 
+    // Delay updating to prevent React from going to infinite loop
+    await Promise.resolve();
+
     this._key = this.props.manager.mount(this.props.children);
   }
 

src/components/__tests__/Portal.test.js

@@ -1,21 +1,21 @@
 /* @flow */
 
 import * as React from 'react';
-import renderer from 'react-test-renderer';
+import { render, waitForElement } from 'react-native-testing-library';
 import { Text } from 'react-native';
 import Portal from '../Portal/Portal';
 
-it('renders portal with siblings', () => {
-  const tree = renderer
-    .create(
-      <Portal.Host>
-        <Text>Outside content</Text>
-        <Portal>
-          <Text>Portal content</Text>
-        </Portal>
-      </Portal.Host>
-    )
-    .toJSON();
+it('renders portal with siblings', async () => {
+  const { toJSON, getByTestId } = render(
+    <Portal.Host>
+      <Text>Outside content</Text>
+      <Portal>
+        <Text testID="content">Portal content</Text>
+      </Portal>
+    </Portal.Host>
+  );
 
-  expect(tree).toMatchSnapshot();
+  await waitForElement(() => getByTestId('content'));
+
+  expect(toJSON()).toMatchSnapshot();
 });

src/components/__tests__/__snapshots__/Portal.test.js.snap

@@ -27,7 +27,9 @@ Array [
       }
     }
   >
-    <Text>
+    <Text
+      testID="content"
+    >
       Portal content
     </Text>
   </View>,

yarn.lock

@@ -7402,6 +7402,13 @@ react-lifecycles-compat@^3.0.4:
   resolved "https://registry.yarnpkg.com/react-lifecycles-compat/-/react-lifecycles-compat-3.0.4.tgz#4f1a273afdfc8f3488a8c516bfda78f872352362"
   integrity sha512-fBASbA6LnOU9dOU2eW7aQ8xmYBSXUIWr+UmF9b1efZBazGNO+rcXT/icdKnYm2pTwcRylVUYwW7H1PHfLekVzA==
 
+react-native-testing-library@^1.5.0:
+  version "1.5.0"
+  resolved "https://registry.yarnpkg.com/react-native-testing-library/-/react-native-testing-library-1.5.0.tgz#02762bf8cb5c1295a220d5e5d40ffc2ebecf31da"
+  integrity sha512-ivS0K0uu8PnAU1DPi2LobZMDcWqQFZUFFP2NiGA1wFKgsGuv2zIGuiBY8mJVAtU2FnPMyVDfg5rL6XoyyCj+jg==
+  dependencies:
+    pretty-format "^23.6.0"
+
 react-native-vector-icons@~6.0.2:
   version "6.0.2"
   resolved "https://registry.yarnpkg.com/react-native-vector-icons/-/react-native-vector-icons-6.0.2.tgz#826252a72d648cf957d46ada8df890318dac53e1"