Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add --example none, --replace-directory, and --skip-git options #668

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add --example none, --replace-directory, and --skip-git options #668

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8a2742
feat: add --example none option to skip example app creation
gabrielmoreira Oct 26, 2024
c72fdd4
feat: add --replace-directory option to overwrite existing directory
gabrielmoreira Oct 26, 2024
9fac75c
feat: add --skip-git option to disable git commands during generation
gabrielmoreira Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 27 additions & 7 deletions packages/create-react-native-library/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ type ArgName =
| 'languages'
| 'type'
| 'local'
| 'skip-git'
| 'replace-directory'
| 'example'
| 'react-native-version';

Expand Down Expand Up @@ -160,6 +162,11 @@ const EXAMPLE_CHOICES = [
value: 'expo',
description: 'managed expo project with web support',
},
{
title: 'None',
value: 'none',
description: 'no example app will be created',
},
] as const;

const NEWARCH_DESCRIPTION = 'requires new arch (experimental)';
Expand Down Expand Up @@ -253,6 +260,14 @@ const args: Record<ArgName, yargs.Options> = {
type: 'string',
choices: EXAMPLE_CHOICES.map(({ value }) => value),
},
'skip-git': {
description: 'Skip git actions',
type: 'boolean',
},
'replace-directory': {
description: 'Replaces the directory if it already exists.',
type: 'boolean',
},
};

// FIXME: fix the type
Expand Down Expand Up @@ -319,7 +334,7 @@ async function create(_argv: yargs.Arguments<any>) {
folder = path.join(process.cwd(), answers.folder);
}

if (await fs.pathExists(folder)) {
if (!argv.replaceDirectory && (await fs.pathExists(folder))) {
console.log(
`A folder already exists at ${kleur.blue(
folder
Expand Down Expand Up @@ -848,6 +863,7 @@ async function create(_argv: yargs.Arguments<any>) {

try {
isInGitRepo =
!argv.skipGit &&
(await spawn('git', ['rev-parse', '--is-inside-work-tree'])) === 'true';
} catch (e) {
// Ignore error
Expand Down Expand Up @@ -933,12 +949,16 @@ async function create(_argv: yargs.Arguments<any>) {
);
} else {
const platforms = {
ios: { name: 'iOS', color: 'cyan' },
android: { name: 'Android', color: 'green' },
...(example === 'none'
? {}
: {
ios: { name: 'iOS', colorize: kleur.cyan },
android: { name: 'Android', colorize: kleur.green },
}),
...(example === 'expo'
? ({ web: { name: 'Web', color: 'blue' } } as const)
? { web: { name: 'Web', colorize: kleur.blue } }
: null),
} as const;
};

console.log(
dedent(`
Expand All @@ -949,8 +969,8 @@ async function create(_argv: yargs.Arguments<any>) {
${kleur.gray('$')} yarn
${Object.entries(platforms)
.map(
([script, { name, color }]) => `
${kleur[color](`Run the example app on ${kleur.bold(name)}`)}${kleur.gray(
([script, { name, colorize }]) => `
${colorize(`Run the example app on ${kleur.bold(name)}`)}${kleur.gray(
':'
)}

Expand Down
Loading