Couple of minor changes to make getting started easier from source #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Made `commit-patch` binary take system env into account for perl binary install location. * Added missing IPC::Run module installation note to README.md.
oneness
force-pushed
the
master
branch
2 times, most recently
from
b7a2704 to
1376b79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, I thank you for this wonderful gem I discovered recently and has already became such an essential tool allowing me to make atomic commits a breeze.
I made following changes and hope it helps others get started with it easier :
commit-patchbinary take system env into account for perl binary install location.This will fix an error on machines that perl is installed in locations other than
/usr/bin/perl. For example, on my M1 Mac, the location is/opt/homebrew/bin/perl.One side effect of this PR is that
commit-patchbinary will not longer has-wperl option by default. Hope you are OK with it since it can be just an alias.