Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: More tracing for handleNewBooking #18233

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

keithwillcode
Copy link
Contributor

@keithwillcode keithwillcode commented Dec 17, 2024

What does this PR do?

Follow up of #18212

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Ensure full test suite passes

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Dec 17, 2024 11:30am
calcom-web-canary ⬜️ Ignored (Inspect) Dec 17, 2024 11:30am

@keithwillcode keithwillcode added core area: core, team members only foundation labels Dec 17, 2024
@keithwillcode keithwillcode self-assigned this Dec 17, 2024
@keithwillcode keithwillcode added this to the v4.9 milestone Dec 17, 2024
@keithwillcode keithwillcode marked this pull request as ready for review December 17, 2024 11:47
@graphite-app graphite-app bot requested a review from a team December 17, 2024 11:47
@dosubot dosubot bot added the performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive label Dec 17, 2024
@keithwillcode keithwillcode enabled auto-merge (squash) December 17, 2024 11:48
Copy link

graphite-app bot commented Dec 17, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (12/17/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@keithwillcode keithwillcode merged commit b0094ba into main Dec 17, 2024
81 of 123 checks passed
@keithwillcode keithwillcode deleted the perf/more-handle-booking-tracing branch December 17, 2024 12:29
Copy link
Contributor

E2E results are ready!

Copy link

sentry-io bot commented Dec 17, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ **PrismaClientValidationError: ** POST /api/bookings View Issue

Did you find this useful? React with a 👍 or 👎

MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only foundation performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants