Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable mandatory reminder for platform #17998

Merged
merged 3 commits into from
Dec 4, 2024
Merged

fix: disable mandatory reminder for platform #17998

merged 3 commits into from
Dec 4, 2024

Conversation

ThyMinimalDev
Copy link
Contributor

@ThyMinimalDev ThyMinimalDev commented Dec 4, 2024 •
edited
Loading

What does this PR do?

Fix platform customer reporting their users are receiving emails even when emails are disabled in oauth client settings. It was identified that the email is coming from mandatory reminder for users using gmail.com. disabling this feature for platform

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@dosubot dosubot bot added emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email platform Anything related to our platform plan 🐛 bug Something isn't working labels Dec 4, 2024
@keithwillcode keithwillcode added the core area: core, team members only label Dec 4, 2024
@graphite-app graphite-app bot requested a review from a team December 4, 2024 11:23
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 4, 2024 •
edited
Loading

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (12/04/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/04/24)

1 label was added to this PR based on Keith Williams's automation.

supalarry
supalarry previously approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@supalarry supalarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good with small comment

packages/features/ee/workflows/lib/reminders/scheduleMandatoryReminder.ts Outdated Show resolved Hide resolved
@vercel Vercel
Copy link

vercel bot commented Dec 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 0:08am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 0:08am

@ThyMinimalDev ThyMinimalDev enabled auto-merge (squash) December 4, 2024 12:09
@ThyMinimalDev ThyMinimalDev merged commit eaff9e8 into main Dec 4, 2024
38 checks passed
@ThyMinimalDev ThyMinimalDev deleted the fix-disable-mandatory-reminder-platform branch December 4, 2024 12:33
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supalarry supalarry supalarry approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working core area: core, team members only emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email platform Anything related to our platform plan ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThyMinimalDev @supalarry @keithwillcode