reuse pre style in calcit #41
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates versioning, dependency versions, and consolidates <pre> and <blockquote> styles into the cirru-based code generator while removing them from the standalone CSS file.
- Bumps package and module versions across
package.json,deps.cirru,compact.cirru, andcalcit.cirru - Migrates
<pre>and<blockquote>styling fromassets/main.cssinto nested&selectors in cirru code - Updates example in
docs/guide.mdand bumps GitHub Action Node version to 24
Reviewed Changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Version bump to 0.0.21; dependency upgrades |
| docs/guide.md | Extended demo string in println call |
| deps.cirru | Updated :calcit-version and Respo sub-dependencies |
| compact.cirru | Version bump; replaced $0 placeholder with & and added nested styles for pre/blockquote |
| calcit.cirru | Version bump; mirrored nested style changes for pre/blockquote |
| assets/main.css | Removed standalone pre and blockquote styles |
| .github/workflows/upload.yaml | Node version updated from 20 to 24 |
Comments suppressed due to low confidence (1)
.github/workflows/upload.yaml:17
- GitHub Actions’
actions/setup-nodeofficially supports Node LTS versions; confirm that Node.js 24 is supported by this action or consider sticking to a current LTS (e.g., 20) to avoid unexpected failures.
node-version: 24
| @@ -3,7 +3,7 @@ | |||
| show you a demo: | |||
|
|
|||
| ``` | |||
| println "|a demo of code" | |||
| println "|a demo of code" "|longlonglonglonglonglonglonglonglonglonglonglonglonglong" | |||
There was a problem hiding this comment.
[nitpick] This line is very long and may hurt readability in the docs. Consider breaking the string into smaller parts or using a multiline code block to demonstrate long output.
| println "|a demo of code" "|longlonglonglonglonglonglonglonglonglonglonglonglonglong" | |
| println "|a demo of code" | |
| "|longlonglonglonglonglonglonglonglonglonglonglonglonglong" |
Copilot uses AI. Check for mistakes.
| :border $ str "\"1px solid " (hsl 0 0 90) | ||
| :border-radius "\"4px" | ||
| :padding "\"2px 2px" | ||
| :margin "\"-2px 2px" | ||
| "\"& pre" $ {} (:background-color "|hsla(0, 0%, 96%, 0.5)") (:border "|1px solid #eee") (:padding "|2px 8px") (:line-height |1.4) (:min-width |400px) (:border-radius |4px) (:overflow |auto) |
There was a problem hiding this comment.
Embedding a large block of CSS directly in the cirru AST can make the code harder to maintain. Consider extracting this style into a reusable CSS module or a shared configuration.
Copilot uses AI. Check for mistakes.
| @@ -1739,6 +1739,70 @@ | |||
| :data $ {} | |||
| |T $ %{} :Leaf (:at 1657312985716) (:by |rJG4IHzWf) (:text |:margin) | |||
| |b $ %{} :Leaf (:at 1657313000582) (:by |rJG4IHzWf) (:text "|\"-2px 2px") | |||
| |h $ %{} :Expr (:at 1750267690164) (:by |rJG4IHzWf) | |||
| :data $ {} | |||
| |T $ %{} :Leaf (:at 1750267693476) (:by |rJG4IHzWf) (:text "|\"& pre") | |||
There was a problem hiding this comment.
This addition mirrors the large inline CSS block from compact.cirru. You might centralize these style definitions or reference a shared helper to reduce duplication across generators.
Copilot uses AI. Check for mistakes.
No description provided.