Fix errors reported by psalm.

Author: ADmad

Association/Loader/SelectLoader.php

@@ -267,7 +267,7 @@ protected function _assertFieldsPresent(Query $fetchQuery, array $key): void
             throw new InvalidArgumentException(
                 sprintf(
                     'You are required to select the "%s" field(s)',
-                    implode(', ', (array)$key)
+                    implode(', ', $key)
                 )
             );
         }

AssociationCollection.php

@@ -311,7 +311,7 @@ protected function _save(
             return true;
         }
         if (!empty($nested)) {
-            $options = (array)$nested + $options;
+            $options = $nested + $options;
         }
 
         return (bool)$association->saveAssociated($entity, $options);

AssociationsNormalizerTrait.php

@@ -47,6 +47,7 @@ protected function _normalizeAssociations($associations): array
 
             $path = explode('.', $table);
             $table = array_pop($path);
+            /** @var string $first */
             $first = array_shift($path);
             $pointer += [$first => []];
             $pointer = &$pointer[$first];

EagerLoadable.php

@@ -217,7 +217,7 @@ public function propertyPath(): ?string
      */
     public function setCanBeJoined(bool $possible)
     {
-        $this->_canBeJoined = (bool)$possible;
+        $this->_canBeJoined = $possible;
 
         return $this;
     }

EagerLoader.php

@@ -308,7 +308,7 @@ public function normalized(Table $repository): array
         $contain = [];
         foreach ($this->_containments as $alias => $options) {
             if (!empty($options['instance'])) {
-                $contain = (array)$this->_containments;
+                $contain = $this->_containments;
                 break;
             }
             $contain[$alias] = $this->_normalizeContain(
@@ -336,7 +336,7 @@ protected function _reformatContain(array $associations, array $original): array
     {
         $result = $original;
 
-        foreach ((array)$associations as $table => $options) {
+        foreach ($associations as $table => $options) {
             $pointer = &$result;
             if (is_int($table)) {
                 $table = $options;
@@ -388,6 +388,7 @@ protected function _reformatContain(array $associations, array $original): array
             }
 
             if (!is_array($options)) {
+                /** @psalm-suppress InvalidArrayOffset */
                 $options = [$options => []];
             }
 

Marshaller.php

@@ -314,7 +314,7 @@ protected function _marshalAssociation(Association $assoc, $value, array $option
         $types = [Association::ONE_TO_ONE, Association::MANY_TO_ONE];
         $type = $assoc->type();
         if (in_array($type, $types, true)) {
-            return $marshaller->one($value, (array)$options);
+            return $marshaller->one($value, $options);
         }
         if ($type === Association::ONE_TO_MANY || $type === Association::MANY_TO_MANY) {
             $hasIds = array_key_exists('_ids', $value);
@@ -328,10 +328,10 @@ protected function _marshalAssociation(Association $assoc, $value, array $option
             }
         }
         if ($type === Association::MANY_TO_MANY) {
-            return $marshaller->_belongsToMany($assoc, $value, (array)$options);
+            return $marshaller->_belongsToMany($assoc, $value, $options);
         }
 
-        return $marshaller->many($value, (array)$options);
+        return $marshaller->many($value, $options);
     }
 
     /**
@@ -748,11 +748,11 @@ protected function _mergeAssociation($original, Association $assoc, $value, arra
         $type = $assoc->type();
         if (in_array($type, $types, true)) {
             /** @psalm-suppress PossiblyInvalidArgument */
-            return $marshaller->merge($original, $value, (array)$options);
+            return $marshaller->merge($original, $value, $options);
         }
         if ($type === Association::MANY_TO_MANY) {
             /** @psalm-suppress PossiblyInvalidArgument */
-            return $marshaller->_mergeBelongsToMany($original, $assoc, $value, (array)$options);
+            return $marshaller->_mergeBelongsToMany($original, $assoc, $value, $options);
         }
 
         if ($type === Association::ONE_TO_MANY) {
@@ -767,7 +767,7 @@ protected function _mergeAssociation($original, Association $assoc, $value, arra
         }
 
         /** @psalm-suppress PossiblyInvalidArgument */
-        return $marshaller->mergeMany($original, $value, (array)$options);
+        return $marshaller->mergeMany($original, $value, $options);
     }
 
     /**

SaveOptionsBuilder.php

@@ -141,7 +141,7 @@ protected function _checkAssociation(Table $table, string $association): void
      */
     public function guard(bool $guard)
     {
-        $this->_options['guard'] = (bool)$guard;
+        $this->_options['guard'] = $guard;
 
         return $this;
     }
@@ -168,7 +168,7 @@ public function validate(string $validate)
      */
     public function checkExisting(bool $checkExisting)
     {
-        $this->_options['checkExisting'] = (bool)$checkExisting;
+        $this->_options['checkExisting'] = $checkExisting;
 
         return $this;
     }
@@ -181,7 +181,7 @@ public function checkExisting(bool $checkExisting)
      */
     public function checkRules(bool $checkRules)
     {
-        $this->_options['checkRules'] = (bool)$checkRules;
+        $this->_options['checkRules'] = $checkRules;
 
         return $this;
     }
@@ -194,7 +194,7 @@ public function checkRules(bool $checkRules)
      */
     public function atomic(bool $atomic)
     {
-        $this->_options['atomic'] = (bool)$atomic;
+        $this->_options['atomic'] = $atomic;
 
         return $this;
     }

Table.php

@@ -420,7 +420,7 @@ public function getAlias(): string
         if ($this->_alias === null) {
             $alias = namespaceSplit(static::class);
             $alias = substr(end($alias), 0, -5) ?: $this->_table;
-            $this->_alias = (string)$alias;
+            $this->_alias = $alias;
         }
 
         return $this->_alias;
@@ -650,7 +650,7 @@ public function setPrimaryKey($key)
     public function getPrimaryKey()
     {
         if ($this->_primaryKey === null) {
-            $key = (array)$this->getSchema()->getPrimaryKey();
+            $key = $this->getSchema()->getPrimaryKey();
             if (count($key) === 1) {
                 $key = $key[0];
             }
@@ -2091,7 +2091,7 @@ protected function _insert(EntityInterface $entity, array $data)
      */
     protected function _newId(array $primary)
     {
-        if (!$primary || count((array)$primary) > 1) {
+        if (!$primary || count($primary) > 1) {
             return null;
         }
         /** @var string $typeName */
@@ -2451,7 +2451,7 @@ protected function _processDelete(EntityInterface $entity, ArrayObject $options)
         }
 
         $query = $this->query();
-        $conditions = (array)$entity->extract($primaryKey);
+        $conditions = $entity->extract($primaryKey);
         $statement = $query->delete()
             ->where($conditions)
             ->execute();