Commit dc4de9c
authored
Fix bugs, typos and loose comparisons (#19199)
* Fix bugs, typos and loose comparisons
Bugs:
- PluginConfig: sprintf format "%ss" -> "%s" (extra 's')
- ExceptionTrap: loose comparison == -> === for object comparison
- Route: loose comparison != -> !== for value comparison
Typos:
- Router: "reverser routing" -> "reverse routing"
- Router/functions: "can be name any" -> "can be any" (4 occurrences)
- ValidatorAwareTrait: "does not exists" -> "does not exist"
- Validation: "and and arrays" -> "and arrays" (2 occurrences)
- Message: "no should more" -> "should not exceed", "no must more" -> "must not exceed"
- Mailer: "Render instance" -> "Renderer instance"
- TransportRegistry: "cache engine" -> "transport" (3 occurrences)
- I18n: "based of" -> "based on" (2 occurrences), "configure" -> "configured"
- ErrorHandlerMiddleware: "contructor" -> "constructor"
- Log: "Cake Logs's" -> "Cake Log's"
- HelperRegistry: "Sets The IO" -> "Sets the IO"
- FileConfigTrait: "with ../" -> "with .." (matches actual check)
- Hash: "file in" -> "find in"
- CookieCryptTrait: "keep keys are" -> "keep keys in"
* Fix Cache documentation errors
- Cache.php: Remove non-existent XcacheEngine, fix "MemcacheEngine" -> "MemcachedEngine"
- MemcachedEngine.php: Fix "MemcacheEngine" -> "MemcachedEngine"
- ApcuEngine.php: Fix "APC" -> "APCu"
* Fix inconsistent @return docblocks
- ArrayLog/ConsoleLog: Remove contradictory "success of write" from @return void
- ArrayEngine/ApcuEngine: Fix redundant "True Returns true" -> "True on success"
* Update test to match corrected error message
* Revert Route.php loose comparison change (intentional for type coercion)1 parent 591587e commit dc4de9c
4 files changed
Lines changed: 6 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
60 | | - | |
| 59 | + | |
| 60 | + | |
61 | 61 | | |
62 | | - | |
63 | 62 | | |
64 | 63 | | |
65 | 64 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
192 | 192 | | |
193 | 193 | | |
194 | 194 | | |
195 | | - | |
| 195 | + | |
196 | 196 | | |
197 | | - | |
| 197 | + | |
198 | 198 | | |
199 | 199 | | |
200 | 200 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
196 | 196 | | |
197 | 197 | | |
198 | 198 | | |
199 | | - | |
| 199 | + | |
200 | 200 | | |
201 | 201 | | |
202 | 202 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
| 75 | + | |
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
| |||
0 commit comments