Skip to content

Conversation

@nils-a
Copy link
Contributor

@nils-a nils-a commented Feb 21, 2021

added a new rule suggest net5.0 when
Cake.Core 1.0.0 is referenced

fixes #76

@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #94 (558b4f7) into develop (8cba2d2) will increase coverage by 2.39%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #94      +/-   ##
===========================================
+ Coverage    75.00%   77.39%   +2.39%     
===========================================
  Files           10       10              
  Lines          224      261      +37     
  Branches        40       45       +5     
===========================================
+ Hits           168      202      +34     
+ Misses          44       41       -3     
- Partials        12       18       +6     
Impacted Files Coverage Δ
src/Tasks/Extensions/VersionExtensions.cs 20.00% <20.00%> (ø)
src/Tasks/TargetFrameworkVersions.cs 85.84% <94.28%> (+10.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cba2d2...558b4f7. Read the comment docs.

added a new rule suggest net5.0 when
Cake.Core 1.0.0 is referenced
Copy link
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nils-a nils-a merged commit b21e6e9 into develop Feb 27, 2021
@nils-a nils-a deleted the feature/GH-76 branch February 27, 2021 22:43
cake-contrib-bot pushed a commit that referenced this pull request Feb 27, 2021
Merge pull request #94 from cake-contrib/feature/GH-76

(GH-76) added net5.0 as suggested for Cake 1.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add rule to suggest net5.0 target for v1.0 release

3 participants