(maint) removed some warnings.

and pinned gh-actions environment.

Author: nils-a

.github/workflows/build.yml

@@ -13,7 +13,7 @@ jobs:
     if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository
     strategy:
       matrix:
-        os: [windows-latest, ubuntu-latest, macos-latest]
+        os:  [ ubuntu-18.04, windows-2019, macos-10.15 ]
 
     steps:
       - uses: actions/checkout@v2.3.4

.github/workflows/codeql-analysis.yml

@@ -17,7 +17,7 @@ on:
 jobs:
   analyze:
     name: Analyze
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
 
     strategy:
       fail-fast: false
@@ -49,7 +49,7 @@ jobs:
         # Prefix the list here with "+" to use these queries and those in the config file.
         # queries: ./path/to/local/query, your-org/your-repo/queries@main
 
-    - run: ./build.ps1
+    - run: ./build.ps1 --target=DotNetCore-Build
       shell: pwsh
 
     - name: Perform CodeQL Analysis

docs/input/guidelines/CakeContribIcon.md

@@ -11,7 +11,6 @@ Title: CakeContrib-Icon
 - [Related rules](#related-rules)
 - [Usage](#usage)
 - [Settings](#settings)
-  - [Icon-Location](#icon-location)
   - [Icon include in project](#icon-include-in-project)
 - [Migrating from an existing project](#migrating-from-an-existing-project)
 

src/Guidelines/build/TargetFrameworkVersions.targets

@@ -14,6 +14,7 @@
         <!-- All other rules have some "configuration" here, this rules required/suggested targets are hard-coded in the task. Sadly. -->
 
         <TargetFrameworkVersions
+            ProjectFile="$(MSBuildProjectFullPath)"
             References="@(PackageReference)"
             TargetFramework="$(TargetFramework)"
             TargetFrameworks="$(TargetFrameworks)"

src/Tasks/CcgLogError.cs

@@ -1,5 +1,7 @@
 using CakeContrib.Guidelines.Tasks.Extensions;
 
+using JetBrains.Annotations;
+
 using Microsoft.Build.Framework;
 using Microsoft.Build.Utilities;
 
@@ -9,6 +11,7 @@ namespace CakeContrib.Guidelines.Tasks
     /// <summary>
     /// This is a convenience-Task to call CcgError from inside the msbuild.
     /// </summary>
+    [UsedImplicitly]
     public class CcgLogError : Task
     {
         /// <summary>

src/Tasks/CcgLogWarning.cs

@@ -1,5 +1,7 @@
 using CakeContrib.Guidelines.Tasks.Extensions;
 
+using JetBrains.Annotations;
+
 using Microsoft.Build.Framework;
 using Microsoft.Build.Utilities;
 
@@ -9,6 +11,7 @@ namespace CakeContrib.Guidelines.Tasks
     /// <summary>
     /// This is a convenience-Task to call CcgWarning from inside the msbuild.
     /// </summary>
+    [UsedImplicitly]
     public class CcgLogWarning : Task
     {
         /// <summary>

src/Tasks/RequiredFileEditorconfig.cs

@@ -14,6 +14,11 @@ namespace CakeContrib.Guidelines.Tasks
     /// </summary>
     public class RequiredFileEditorconfig : Task
     {
+#if DEBUG
+        private const MessageImportance LogLevel = MessageImportance.High;
+#else
+        private const MessageImportance LogLevel = MessageImportance.Low;
+#endif
         private const string FileName = ".editorconfig";
 
         /// <summary>
@@ -49,7 +54,7 @@ public override bool Execute()
                 .Where(x => !string.IsNullOrEmpty(x))
                 .Any(x => x.Equals(FileName, StringComparison.OrdinalIgnoreCase)))
             {
-                Log.LogMessage(MessageImportance.Low, $"Recommended file '{FileName}' is set to omit.");
+                Log.LogMessage(LogLevel, $"Recommended file '{FileName}' is set to omit.");
                 return true;
             }
 

src/Tasks/TargetFrameworkVersions.cs

@@ -100,6 +100,12 @@ public class TargetFrameworkVersions : Task
         /// </summary>
         public ITaskItem[] Omitted { get; set; }
 
+        /// <summary>
+        /// Gets or sets the project file.
+        /// </summary>
+        [Required]
+        public string ProjectFile { get; set; }
+
         /// <inheritdoc />
         public override bool Execute()
         {
@@ -118,7 +124,7 @@ public override bool Execute()
             {
                 Log.CcgWarning(
                     7,
-                    BuildEngine.ProjectFileOfTaskNode,
+                    ProjectFile,
                     $"Cake.Core has a version of {cakeCore.GetMetadata("version")} which is not a valid version. Using default TargetVersions.");
                 return Execute(DefaultTarget);
             }
@@ -195,7 +201,7 @@ private bool Execute(TargetsDefinitions targets)
 
                 Log.CcgError(
                     7,
-                    BuildEngine.ProjectFileOfTaskNode,
+                    ProjectFile,
                     "Missing required target: " + requiredTarget.Name);
                 return false;
             }
@@ -228,7 +234,7 @@ private bool Execute(TargetsDefinitions targets)
 
                 Log.CcgWarning(
                     7,
-                    BuildEngine.ProjectFileOfTaskNode,
+                    ProjectFile,
                     "Missing suggested target: " + suggestedTarget.Name);
             }
 

src/Tasks/Tasks.csproj

@@ -14,6 +14,7 @@
     </ItemGroup>
 
     <ItemGroup>
+        <PackageReference Include="JetBrains.Annotations" Version="2020.3.0" />
         <PackageReference Include="Microsoft.Build.Utilities.Core" Version="16.9.0" CopyLocal="false" Publish="false" ExcludeAssets="runtime" PrivateAssets="All" />
         <PackageReference Include="Microsoft.Build.Framework" Version="16.9.0" CopyLocal="false" Publish="false" ExcludeAssets="runtime" PrivateAssets="All" />
         <PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="5.0.3">

src/Tasks/Testability/FileSearcher.cs

@@ -1,25 +1,28 @@
+using System;
+using System.Diagnostics.CodeAnalysis;
 using System.IO;
 
 namespace CakeContrib.Guidelines.Tasks.Testability
 {
     /// <inheritdoc />
+    [ExcludeFromCodeCoverage]
     internal class FileSearcher : IFileSearcher
     {
         /// <inheritdoc />
         public bool HasFileInFolderStructure(string startFolder, string fileName)
         {
             var folder = startFolder;
-            var found = false;
-            while (folder != null && !found)
+            do
             {
-                found = File.Exists(Path.Combine(folder, fileName));
+                var found = File.Exists(Path.Combine(folder, fileName));
                 if (found)
                 {
                     return true;
                 }
 
                 folder = Path.GetDirectoryName(folder);
             }
+            while (folder != null);
 
             return false;
         }