Merge branch 'hotfix/0.9.1'

Author: pascalberger

src/Cake.Issues.InspectCode.Tests/Cake.Issues.InspectCode.Tests.csproj

@@ -16,11 +16,13 @@
 
   <ItemGroup>
     <None Remove="Testfiles\inspectcode.xml" />
+    <None Remove="Testfiles\WithoutLineButOffset.xml" />
     <None Remove="Testfiles\WithWikiUrl.xml" />
   </ItemGroup>
 
   <ItemGroup>
     <EmbeddedResource Include="Testfiles\inspectcode.xml" />
+    <EmbeddedResource Include="Testfiles\WithoutLineButOffset.xml" />
     <EmbeddedResource Include="Testfiles\WithWikiUrl.xml" />
   </ItemGroup>
 

src/Cake.Issues.InspectCode.Tests/InspectCodeIssuesProviderTests.cs

@@ -62,6 +62,31 @@ public void Should_Read_Issue_Correct()
                         .Create());
             }
 
+            [Fact]
+            public void Should_Read_Issue_Without_Line_Correct()
+            {
+                // Given
+                var fixture = new InspectCodeIssuesProviderFixture("WithoutLineButOffset.xml");
+
+                // When
+                var issues = fixture.ReadIssues().ToList();
+
+                // Then
+                issues.Count.ShouldBe(1);
+                var issue = issues.Single();
+                IssueChecker.Check(
+                    issue,
+                    IssueBuilder.NewIssue(
+                        @"Using directive is not required by the code and can be safely removed",
+                        "Cake.Issues.InspectCode.InspectCodeIssuesProvider",
+                        "InspectCode")
+                        .InProjectOfName("Project1")
+                        .InFile(@"Src\myfile.cs", 1)
+                        .OfRule("RedundantUsingDirective", new Uri("https://www.jetbrains.com/resharperplatform/help?Keyword=RedundantUsingDirective"))
+                        .WithPriority(IssuePriority.Warning)
+                        .Create());
+            }
+
             [Fact]
             public void Should_Read_Rule_Url()
             {

src/Cake.Issues.InspectCode.Tests/Testfiles/WithoutLineButOffset.xml

@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Generated by JetBrains Inspect Code 2021.1.3 -->
+
+<Report ToolsVersion="211.0.20210525.205200">
+  <Information>
+    <Solution>Temp.sln</Solution>
+    <InspectionScope>
+      <Element>Solution</Element>
+    </InspectionScope>
+  </Information>
+  <IssueTypes>
+    <IssueType Id="RedundantUsingDirective" Category="Redundancies in Code" CategoryId="CodeRedundancy" Description="Redundant using directive" Severity="WARNING" WikiUrl="https://www.jetbrains.com/resharperplatform/help?Keyword=RedundantUsingDirective" />
+  </IssueTypes>
+  <Issues>
+    <Project Name="Project1">
+      <Issue TypeId="RedundantUsingDirective" File="Src\myfile.cs" Offset="0-48" Message="Using directive is not required by the code and can be safely removed" />
+    </Project>
+  </Issues>
+</Report>

src/Cake.Issues.InspectCode/InspectCodeIssuesProvider.cs

@@ -174,7 +174,18 @@ private static bool TryGetLine(XElement issue, out int line)
             var lineValue = lineAttr?.Value;
             if (string.IsNullOrWhiteSpace(lineValue))
             {
-                return false;
+                var offsetAttr = issue.Attribute("Offset");
+
+                var offsetValue = offsetAttr?.Value;
+                if (string.IsNullOrWhiteSpace(offsetValue))
+                {
+                    return false;
+                }
+
+                // There are cases where InspectCode reports an offset, but no line.
+                // In this case we will assume line 1.
+                line = 1;
+                return true;
             }
 
             line = int.Parse(lineValue, CultureInfo.InvariantCulture);