Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cake --boostrap should uninstall and/or use same as specified in #module directive #2525

Open
devlead opened this issue Apr 9, 2019 · 3 comments

Comments

@devlead
Copy link
Member

devlead commented Apr 9, 2019

I updated a script from

#module nuget:?package=Cake.DotNetTool.Module&version=0.1.0

to

#module nuget:?package=Cake.DotNetTool.Module&version=0.2.0

--bootstrap installed the new version of the module, but the old one is still there

tools\modules
+---Cake.DotNetTool.Module.0.1.0
|   \---lib
|       \---netstandard2.0
\---Cake.DotNetTool.Module.0.2.0
    \---lib
        \---netstandard2.0

and the old being loaded and warnings still present even new available

- The assembly 'Cake.DotNetTool.Module, Version=0.1.0.0, Culture=neutral, PublicKeyToken=null'
- is referencing an older version of Cake.Core (0.30.0).
- For best compatibility it should target Cake.Core version 0.33.0.
- Could not load module - '/tools/Modules/Cake.DotNetTool.Module.0.2.0/lib/netstandard2.0/Cake.DotNetTool.Module.dll'.

Expected behavior would be to load the new version.

Possible solutions would be to uninstall versions that don't match during bootstrap, load latest version of each module, find a way for assembly scanning to pick specified version.

@cake-build/cake-team thoughts?

@gep13
Copy link
Member

gep13 commented Apr 9, 2019

@devlead this seems like a good idea to me.

@patriksvensson
Copy link
Member

@gep13 @devlead Perhaps we can wait with this one until #2333 have been merged?

@devlead
Copy link
Member Author

devlead commented Apr 9, 2019

@patriksvensson sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants