Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide headings for delegating tasks at normal verbosity #2344

Open
patriksvensson opened this issue Oct 29, 2018 · 3 comments
Open

Hide headings for delegating tasks at normal verbosity #2344

patriksvensson opened this issue Oct 29, 2018 · 3 comments

Comments

@patriksvensson
Copy link
Member

patriksvensson commented Oct 29, 2018

If we consider the following script, that has one task that does something (Default) and two delegating tasks that doesn't have any actions:

Task("Foo");

Task("Bar")
    .IsDependentOn("Foo");

Task("Default")
    .IsDependentOn("Bar")
    .Does(() =>
{
    Information("Hello Cake!");
});

RunTarget("Default");

If I run this with normal verbosity, I get the following output.

========================================
Foo
========================================

========================================
Bar
========================================

========================================
Default
========================================
Hello Cake!

Task                          Duration
--------------------------------------------------
Default                       00:00:00.0012661
--------------------------------------------------
Total:                        00:00:00.0126071

I've actually never thought about this, but why are we showing the headers of delegating tasks when we're explicitly only show delegating tasks with verbose verbosity?

Proposed change:

I think that we shouldn't show the heading (which does not convey any meaning since they're only delegating) on normal verbosity. The more I think about it, I don't see a good reason to show the headings at all, except perhaps on diagnostic verbosity.

We should however consider displaying the delegating tasks in the summary view on normal verbosity and hide the headings. The delegating tasks in the summary view would be gray like on verbose verbosity.

========================================
Default
========================================
Hello Cake!

Task                          Duration
--------------------------------------------------
Foo                           00:00:00.0152253
Bar                           00:00:00.0142460
Default                       00:00:00.0087549
--------------------------------------------------
Total:                        00:00:00.0382262
@patriksvensson
Copy link
Member Author

If no one have any objections I will add a PR for this tonight.
Ping @cake-build/cake-team

@pascalberger
Copy link
Member

OK for me

@devlead
Copy link
Member

devlead commented Oct 30, 2018

Ok for me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants