Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that OpenSearch client not use external version for index requests #6368

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

neil-xie
Copy link
Member

What changed?
It is causing issue when reindexed from ElasticSearch during migration since the version is not respected

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.87%. Comparing base (f7054a5) to head (733d260).
Report is 1 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
common/elasticsearch/client/os2/client_bulk.go 92.52% <100.00%> (+0.14%) ⬆️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7054a5...733d260. Read the comment docs.

@neil-xie neil-xie merged commit 100562f into cadence-workflow:master Oct 16, 2024
20 checks passed
@neil-xie neil-xie deleted the CDNC-10434-fix branch October 16, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants