Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fx docker template and canary batcher workflow #4585

Merged
merged 5 commits into from
Oct 19, 2021

Conversation

longquanzheng
Copy link
Contributor

What changed?
Fx docker template and canary batcher workflow

Why?

  1. a bad change is merge in the MR(from my auto saving in my IDE) it should be {{ instead of { {
  2. the current batcher canary is broken.

How did you test it?

Potential risks

Release notes

Documentation Changes

@longquanzheng longquanzheng requested review from yux0 and yycptt October 19, 2021 21:38
@longquanzheng longquanzheng enabled auto-merge (squash) October 19, 2021 22:09
@longquanzheng longquanzheng merged commit 5affa4f into master Oct 19, 2021
@longquanzheng longquanzheng deleted the qlong-fix-docker-template-canary-batcher branch October 19, 2021 22:25
@coveralls
Copy link

Pull Request Test Coverage Report for Build a950b6ec-aca5-4590-8904-45a520b7bd6d

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 72 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.01%) to 56.81%

Files with Coverage Reduction New Missed Lines %
client/history/client.go 2 40.32%
client/history/metricClient.go 2 45.94%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/execution/mutable_state_builder.go 2 69.77%
service/history/handler.go 2 48.32%
service/matching/taskListManager.go 2 74.66%
service/history/queue/timer_gate.go 3 95.83%
service/frontend/workflowHandler.go 4 58.59%
common/task/fifoTaskScheduler.go 5 84.54%
common/persistence/nosql/nosqlExecutionStore.go 9 60.35%
Totals Coverage Status
Change from base Build 0daa053c-e8f1-4f79-9482-b35ead076b5a: -0.01%
Covered Lines: 81479
Relevant Lines: 143424

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants