Moved RPC related types to a dedicated package #4505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build d6fcb8ae-0329-4864-8f23-1582e6a7502b
💛 - Coveralls |
meiliang86
approved these changes
Sep 23, 2021
mantas-sidlauskas
approved these changes
Sep 24, 2021
common/rpc/factory.go
Outdated
| config *RPC | ||
| // Factory is an implementation of service.RPCFactory interface | ||
| type Factory struct { | ||
| config config.RPC | ||
| serviceName string | ||
| ch *tchannel.ChannelTransport |
There was a problem hiding this comment.
nit and not directly related to this change: rename ch to tchannel?
There was a problem hiding this comment.
Agree, fixed.
common/rpc/factory.go
Outdated
| func newRPCFactory(cfg *RPC, sName string, logger log.Logger, grpcPorts GRPCPorts) *RPCFactory { | ||
| factory := &RPCFactory{config: cfg, serviceName: sName, logger: logger, grpcPorts: grpcPorts} | ||
| return factory | ||
| func NewFactory(sName string, cfg config.RPC, logger log.Logger, grpcPorts GRPCPorts) *Factory { |
There was a problem hiding this comment.
nit and not directly related to this change: sName -> name or service
There was a problem hiding this comment.
Agree, fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Moved RPC related stuff from
configpackage to a dedicatedrpcpackage, with minor renaming and splitting into files.Why?
These types contain significant amount of RPC related logic, that IMO deserves their own place. Those are not very config related.
Also, this serves as a first refactoring step for further changes planned. Specifically unifying how dispatchers are created and used. This includes
DispatcherProviderand all related stuff such asdnsDispatcherProvider,dnsUpdater, etc. Currently they lie underclientpackage. In the end, these types will end up here as well.How did you test it?
Existing tests.
Potential risks
None, only mechanical move.
Release notes
Documentation Changes