Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme changes #2

Closed
wants to merge 1 commit into from
Closed

readme changes #2

wants to merge 1 commit into from

Conversation

samarabbas
Copy link
Contributor

No description provided.

@samarabbas samarabbas requested a review from sivakku February 22, 2017 19:41
@samarabbas samarabbas closed this Feb 22, 2017
@samarabbas samarabbas deleted the readme-edit branch February 22, 2017 20:57
mfateev pushed a commit to mfateev/cadence that referenced this pull request Sep 9, 2018
@uber-qlam
Test GetDomain with blank id and name (cadence-workflow#2)
abf6456
samarabbas pushed a commit that referenced this pull request Sep 14, 2018
@mfateev @samarabbas
Refactoring of persistence unit tests (#1111)
1a22c01 
* Implement metadata persistence in SQL

This implementation (sqlMetadataPersistence.go) implements the
following "v2" MetadataManager interface:

- CreateDomain
- GetDomain
- UpdateDomain
- DeleteDomain
- DeleteDomainByName
- ListDomain
- GetMetadata

The test creates and deletes the table in "sql/domains.sql" by itself.
You just need to stand up a MySQL instance with a
databased named "catalyst_test".
At the moment everything is hardcoded to
use uber:uber@localhost:3306
with database "catalyst_test". This should be generalized.

* Test GetDomain with blank id and name (#2)

* Big rename (#3)

Put Cassandra and SQL implementations and the common tests into separate packages under `persistence`

* Shard persistence, some executions persistence (#4)

* Pass TestPersistenceStartWorkflow, TestGetWorkflow, TestCreateGetUpdateGetShard
* Moved SQL scripts into one file

* Pass some more tests (#5)

* Pass TestUpdateWorkflow

* Pass TestGetCurrentWorkflow

* Pass  TestPersistenceStartWorkflowWithReplicationState

Perturb test slightly to force ShardOwnershipLost instead of WorkflowAlredyExists

* Pass TestDeleteWorkflow

* TestTransferTasksThroughUpdate

* Pass TestCancelTransferTaskTasks

* Pass TestSignalTransferTaskTasks, TestCreateTask

* Pass TestLeaseAndUpdateTaskList

* add stubs

* Put transferTaskTypeTransferTargetRunID back in cassandra; remove superfluous WHERE conditions

* More readable variable names

* Add error if getTaskList fails with error other than errNoRows

* Add field names for struct literals

* Add logger member to task persistence so we can panic, like the Cassandra impl does

* typo: forgot to add logger argument after adding logger parameter to constructor

* TestLeaseAndUpdateTaskList_Sticky, TestGetDecisionTasks, TestComplete… (#7)

* TestLeaseAndUpdateTaskList_Sticky, TestGetDecisionTasks, TestCompleteDecisionTask, TestReplicationTasks, TestTimerTasks
* Add & to struct arguments for named SQL queries
* Add error handling on type casts. This causes one of the tests to stop panicking

* ContinueAsNew
==
Squashed commit of the following:

commit 7a626d9
Author: Quincy Lam <qlam@uber.com>
Date:   Mon Jul 30 19:20:19 2018 -0700

    Delete panics

commit 14cb2c3
Author: Quincy Lam <qlam@uber.com>
Date:   Mon Jul 30 19:17:51 2018 -0700

    Pass

commit 04ae7b9
Author: Quincy Lam <qlam@uber.com>
Date:   Mon Jul 30 17:33:03 2018 -0700

    almost

* TestCreateGetShard_Backfill

Squashed commit of the following:

commit 05b0ddd
Author: Quincy Lam <qlam@uber.com>
Date:   Mon Jul 30 21:12:40 2018 -0700

    Pass

* TestWorkflowReplicationState

Squashed commit of the following:

commit 5ac28b4
Author: Quincy Lam <qlam@uber.com>
Date:   Tue Jul 31 13:48:09 2018 -0700

    Pass

* History persistence

Squashed commit of the following:

commit a86050e
Author: Quincy Lam <qlam@uber.com>
Date:   Thu Aug 2 14:38:16 2018 -0700

    use  error message to inspect duplicate key insert failure

commit d60de82
Author: Quincy Lam <qlam@uber.com>
Date:   Thu Aug 2 14:13:50 2018 -0700

    reorder imports

commit 774fe2a
Author: Quincy Lam <qlam@uber.com>
Date:   Thu Aug 2 14:10:34 2018 -0700

    Const queries

commit da7ab8d
Author: Quincy Lam <qlam@uber.com>
Date:   Wed Aug 1 22:15:27 2018 -0700

    Pass TestDeleteHistoryEvents

commit c2978a2
Author: Quincy Lam <qlam@uber.com>
Date:   Wed Aug 1 22:07:33 2018 -0700

    Pass TestGetHistoryEvents, TestGetHistoryEventsCompatibility

commit c775b53
Author: Quincy Lam <qlam@uber.com>
Date:   Wed Aug 1 21:44:27 2018 -0700

    TestAppendHistoryEvents

* Mutable state; fixed possible regression with TestWorkflowReplicationState

Squashed commit of the following:

commit a0f75b1
Author: Quincy Lam <qlam@uber.com>
Date:   Fri Aug 3 01:25:43 2018 -0700

    Pass TestResetMutableState

commit ef41d12
Author: Quincy Lam <qlam@uber.com>
Date:   Thu Aug 2 23:51:13 2018 -0700

    Fix regression with GetWorkflow (need to check if execution row exists before locking it; otherwise return EntityNotExists in order to pass DeleteWorkflow test)

commit fd485d9
Author: Quincy Lam <qlam@uber.com>
Date:   Thu Aug 2 23:35:35 2018 -0700

    Pass TestWorkflowMutableState_SignalRequested

commit d0a2c79
Author: Quincy Lam <qlam@uber.com>
Date:   Thu Aug 2 22:35:26 2018 -0700

    Pass TestWorkflowMutableState_BufferedReplicationTasks

commit 6d220db
Author: Quincy Lam <qlam@uber.com>
Date:   Thu Aug 2 21:47:22 2018 -0700

    Pass TestWorkflowMutableState_SignalInfo

commit 2115127
Author: Quincy Lam <qlam@uber.com>
Date:   Thu Aug 2 21:17:00 2018 -0700

    Request cancel info

commit 79733c2
Author: Quincy Lam <qlam@uber.com>
Date:   Thu Aug 2 20:42:49 2018 -0700

    parent executions; TestWorkflowMutableState_ChildExecutions

commit 2751bf1
Author: Quincy Lam <qlam@uber.com>
Date:   Thu Aug 2 18:02:54 2018 -0700

    Pass TestWorkflowMutableState_Timers

commit 72b99de
Author: Quincy Lam <qlam@uber.com>
Date:   Thu Aug 2 16:08:56 2018 -0700

    Make some better query templates

commit 6ec3532
Author: Quincy Lam <qlam@uber.com>
Date:   Tue Jul 31 23:11:47 2018 -0700

    Pass TestWorkflowMutableState_Activities

* go fmt, rename GetVisilibityTS

* Add branches with sql stuff

* deleted and rebuilt glide.lock

* typos with the branches

* Add metadata switch

* Add history branch

* Pass shard persistence tests

* hello world with sql executions+metadata+history+shards works

* Some debugging prompts

* childworkflow works

The bug was that createTimerTasks within ContinueAsNew logic was being caled on the transfer tasks. THere should be a test to make sure this typo doesn't occur

* Added MapperFunc to sql db field mapping

* Fixed syntax errors

* Moved from hmgle/sqlx to jmoiron/sqlx with batch update patch

* Renamed TestBase.CassandraTestCluster to PersistenceTestCluster

* Refactored persistence unit tests to support shared tests for various backends

* Renamed TestBaseOptions.Cluster... to DB...

* IUpdated CassandraTestCluster methods to more generic names

* Refactored cassandra test initialization out of persistence-tests

* Removed SQL implementation

* Linter fixes

* Removed config changes

* Renamed persistence to p prefix

* Renamed persistence to p prefix in cassandra package

* Renamed persistence to p prefix in service packages

* PR comments

* Added InitTestSuiteWithMetadata and fixed Integration_domain_failover_test
venkat1109 pushed a commit that referenced this pull request Sep 19, 2018
@mfateev @venkat1109
SQL Persistence Implementation (#1121)
ca90227 
* Implement metadata persistence in SQL

This implementation (sqlMetadataPersistence.go) implements the
following "v2" MetadataManager interface:

- CreateDomain
- GetDomain
- UpdateDomain
- DeleteDomain
- DeleteDomainByName
- ListDomain
- GetMetadata

The test creates and deletes the table in "sql/domains.sql" by itself.
You just need to stand up a MySQL instance with a
databased named "catalyst_test".
At the moment everything is hardcoded to
use uber:uber@localhost:3306
with database "catalyst_test". This should be generalized.

* Test GetDomain with blank id and name (#2)

* Big rename (#3)

Put Cassandra and SQL implementations and the common tests into separate packages under `persistence`

* Shard persistence, some executions persistence (#4)

* Pass TestPersistenceStartWorkflow, TestGetWorkflow, TestCreateGetUpdateGetShard
* Moved SQL scripts into one file

* Pass some more tests (#5)

* Pass TestUpdateWorkflow

* Pass TestGetCurrentWorkflow

* Pass  TestPersistenceStartWorkflowWithReplicationState

Perturb test slightly to force ShardOwnershipLost instead of WorkflowAlredyExists

* Pass TestDeleteWorkflow

* TestTransferTasksThroughUpdate

* Pass TestCancelTransferTaskTasks

* Pass TestSignalTransferTaskTasks, TestCreateTask

* Pass TestLeaseAndUpdateTaskList

* add stubs

* Put transferTaskTypeTransferTargetRunID back in cassandra; remove superfluous WHERE conditions

* More readable variable names

* Add error if getTaskList fails with error other than errNoRows

* Add field names for struct literals

* Add logger member to task persistence so we can panic, like the Cassandra impl does

* typo: forgot to add logger argument after adding logger parameter to constructor

* TestLeaseAndUpdateTaskList_Sticky, TestGetDecisionTasks, TestComplete… (#7)

* TestLeaseAndUpdateTaskList_Sticky, TestGetDecisionTasks, TestCompleteDecisionTask, TestReplicationTasks, TestTimerTasks
* Add & to struct arguments for named SQL queries
* Add error handling on type casts. This causes one of the tests to stop panicking

* ContinueAsNew
==
Squashed commit of the following:

commit 7a626d9
Author: Quincy Lam <qlam@uber.com>
Date:   Mon Jul 30 19:20:19 2018 -0700

    Delete panics

commit 14cb2c3
Author: Quincy Lam <qlam@uber.com>
Date:   Mon Jul 30 19:17:51 2018 -0700

    Pass

commit 04ae7b9
Author: Quincy Lam <qlam@uber.com>
Date:   Mon Jul 30 17:33:03 2018 -0700

    almost

* TestCreateGetShard_Backfill

Squashed commit of the following:

commit 05b0ddd
Author: Quincy Lam <qlam@uber.com>
Date:   Mon Jul 30 21:12:40 2018 -0700

    Pass

* TestWorkflowReplicationState

Squashed commit of the following:

commit 5ac28b4
Author: Quincy Lam <qlam@uber.com>
Date:   Tue Jul 31 13:48:09 2018 -0700

    Pass

* History persistence

Squashed commit of the following:

commit a86050e
Author: Quincy Lam <qlam@uber.com>
Date:   Thu Aug 2 14:38:16 2018 -0700

    use  error message to inspect duplicate key insert failure

commit d60de82
Author: Quincy Lam <qlam@uber.com>
Date:   Thu Aug 2 14:13:50 2018 -0700

    reorder imports

commit 774fe2a
Author: Quincy Lam <qlam@uber.com>
Date:   Thu Aug 2 14:10:34 2018 -0700

    Const queries

commit da7ab8d
Author: Quincy Lam <qlam@uber.com>
Date:   Wed Aug 1 22:15:27 2018 -0700

    Pass TestDeleteHistoryEvents

commit c2978a2
Author: Quincy Lam <qlam@uber.com>
Date:   Wed Aug 1 22:07:33 2018 -0700

    Pass TestGetHistoryEvents, TestGetHistoryEventsCompatibility

commit c775b53
Author: Quincy Lam <qlam@uber.com>
Date:   Wed Aug 1 21:44:27 2018 -0700

    TestAppendHistoryEvents

* Mutable state; fixed possible regression with TestWorkflowReplicationState

Squashed commit of the following:

commit a0f75b1
Author: Quincy Lam <qlam@uber.com>
Date:   Fri Aug 3 01:25:43 2018 -0700

    Pass TestResetMutableState

commit ef41d12
Author: Quincy Lam <qlam@uber.com>
Date:   Thu Aug 2 23:51:13 2018 -0700

    Fix regression with GetWorkflow (need to check if execution row exists before locking it; otherwise return EntityNotExists in order to pass DeleteWorkflow test)

commit fd485d9
Author: Quincy Lam <qlam@uber.com>
Date:   Thu Aug 2 23:35:35 2018 -0700

    Pass TestWorkflowMutableState_SignalRequested

commit d0a2c79
Author: Quincy Lam <qlam@uber.com>
Date:   Thu Aug 2 22:35:26 2018 -0700

    Pass TestWorkflowMutableState_BufferedReplicationTasks

commit 6d220db
Author: Quincy Lam <qlam@uber.com>
Date:   Thu Aug 2 21:47:22 2018 -0700

    Pass TestWorkflowMutableState_SignalInfo

commit 2115127
Author: Quincy Lam <qlam@uber.com>
Date:   Thu Aug 2 21:17:00 2018 -0700

    Request cancel info

commit 79733c2
Author: Quincy Lam <qlam@uber.com>
Date:   Thu Aug 2 20:42:49 2018 -0700

    parent executions; TestWorkflowMutableState_ChildExecutions

commit 2751bf1
Author: Quincy Lam <qlam@uber.com>
Date:   Thu Aug 2 18:02:54 2018 -0700

    Pass TestWorkflowMutableState_Timers

commit 72b99de
Author: Quincy Lam <qlam@uber.com>
Date:   Thu Aug 2 16:08:56 2018 -0700

    Make some better query templates

commit 6ec3532
Author: Quincy Lam <qlam@uber.com>
Date:   Tue Jul 31 23:11:47 2018 -0700

    Pass TestWorkflowMutableState_Activities

* go fmt, rename GetVisilibityTS

* Add branches with sql stuff

* deleted and rebuilt glide.lock

* typos with the branches

* Add metadata switch

* Add history branch

* Pass shard persistence tests

* hello world with sql executions+metadata+history+shards works

* Some debugging prompts

* childworkflow works

The bug was that createTimerTasks within ContinueAsNew logic was being caled on the transfer tasks. THere should be a test to make sure this typo doesn't occur

* Added MapperFunc to sql db field mapping

* Fixed syntax errors

* Moved from hmgle/sqlx to jmoiron/sqlx with batch update patch

* Renamed TestBase.CassandraTestCluster to PersistenceTestCluster

* Refactored persistence unit tests to support shared tests for various backends

* Renamed TestBaseOptions.Cluster... to DB...

* IUpdated CassandraTestCluster methods to more generic names

* Refactored cassandra test initialization out of persistence-tests

* Removed extra imports after the merge

* Moved sql schema to schema/mysql directory

* Renamed sql schema files to match cassandra ones

* historyPersistence_test passing with exception of pagination queries

* Added getHistory pagination. All historyPersistence unit tests passing

* Disabled broken sql persistence unit tests. Lint fixes

* Disabled all SQL tests to enable travis build

* Enabled MySQL on travis and enabled historyPersistence and shardPersistence unit tests for SQL

* Removed unused variables from TestSignalFailover
longquanzheng added a commit that referenced this pull request Apr 15, 2019
@longquanzheng
Logging refactor #2: rename old logger and Initialize new logger, and…
b6ab415 
… apply new logger in frontend (#1698)

* pick log2

* remove unused

* add panic helper

* apply panic helper

* fix integ test

* fix

* fix

* fix conflict

* fix compile

* fix

* fix
lihannan99 pushed a commit that referenced this pull request Apr 18, 2019
@longquanzheng @lihannan99
Logging refactor #2: rename old logger and Initialize new logger, and…
7242b47 
… apply new logger in frontend (#1698)

* pick log2

* remove unused

* add panic helper

* apply panic helper

* fix integ test

* fix

* fix

* fix conflict

* fix compile

* fix

* fix
kewu21 pushed a commit to kewu21/cadence that referenced this pull request Oct 16, 2019
@barakalon
[EMERGENCY MERGE] Barak deploy to sde 2 (cadence-workflow#2)
71591af 
This PR used Merge Queue's emergency enqueue, and did not require tests to pass before merging.
@longquanzheng longquanzheng mentioned this pull request Jan 22, 2021
Open
vytautas-karpavicius added a commit that referenced this pull request Oct 5, 2021
@vytautas-karpavicius
Use common dispatcher for public client outbound #2 (#4537)
b1e3001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivakku sivakku sivakku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samarabbas @sivakku