-
Notifications
You must be signed in to change notification settings - Fork 118
Feature/adding query md experimental support #923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
davidporter-id-au
merged 9 commits into
cadence-workflow:master
from
davidporter-id-au:feature/adding-query-md-experimental-support
Jun 17, 2025
Merged
Feature/adding query md experimental support #923
davidporter-id-au
merged 9 commits into
cadence-workflow:master
from
davidporter-id-au:feature/adding-query-md-experimental-support
Jun 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/views/workflow-queries/workflow-queries-result/workflow-queries-result.tsx
Outdated
Show resolved
Hide resolved
Assem-Uber
reviewed
Jun 6, 2025
src/views/workflow-queries/workflow-queries-result/helpers/get-query-json-content.ts
Outdated
Show resolved
Hide resolved
src/views/workflow-queries/workflow-queries-result/helpers/get-query-json-content.ts
Outdated
Show resolved
Hide resolved
src/views/workflow-queries/workflow-queries-result/workflow-queries-result.tsx
Outdated
Show resolved
Hide resolved
...ews/workflow-queries/workflow-queries-result/__tests__/workflow-queries-result-json.test.tsx
Show resolved
Hide resolved
src/views/workflow-queries/workflow-queries-result/workflow-queries-result.tsx
Outdated
Show resolved
Hide resolved
src/views/workflow-queries/workflow-queries-result/workflow-queries-result.types.ts
Outdated
Show resolved
Hide resolved
Assem-Uber
approved these changes
Jun 17, 2025
Keeping the test text for reference
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental feature which allows a query to return preformatted data (in this instance markdown, though if it's useful, presumably other types as well).
This is still being tested, so it's not going to be super discoverable (and I have no idea what I'm doing on the frontend, so also will try and wall off these changes for a bit until we're more certain they'll be of use).
The idea is that a query should be able return a response struct like this:
for example:
where
cadenceResponseType
is expected to always be the fixed stringformattedData
andformat
refers to the mime-type classification.If it works, and if the format returned is supported, this can be rendered in the query UI. The react-md package in this instance takes care to sanitize the inputs since this would otherwise be an obvious XSS vector.
Testing: