From fbb4a1b502b163867e45176efa8e0fd575449b49 Mon Sep 17 00:00:00 2001
From: Bowei Xu <boweixu@uber.com>
Date: Thu, 8 Aug 2019 16:57:59 -0700
Subject: [PATCH] Support list workflows with SQL like query (#55)

* Fix missing dependencies

* Add support to list workflow using SQL like query

* Address comments
---
 client/routes/Workflows.vue          | 90 ++++++++++++++++++----------
 package.json                         |  4 +-
 server/middleware/tchannel-client.js |  1 +
 server/routes.js                     |  8 +++
 4 files changed, 72 insertions(+), 31 deletions(-)

diff --git a/client/routes/Workflows.vue b/client/routes/Workflows.vue
index 066653faf..faa91302f 100644
--- a/client/routes/Workflows.vue
+++ b/client/routes/Workflows.vue
@@ -1,34 +1,48 @@
 <template>
   <section :class="{ workflows: true, loading }">
     <header class="filters">
-      <div class="field workflow-id">
-        <input type="search" class="workflow-id"
-          placeholder=" "
-          name="workflowId"
-          v-bind:value="$route.query.workflowId"
-          @input="setWorkflowFilter" />
-        <label for="workflowId">Workflow ID</label>
-      </div>
-      <div class="field workflow-name">
-        <input type="search" class="workflow-name"
-          placeholder=" "
-          name="workflowName"
-          v-bind:value="$route.query.workflowName"
-          @input="setWorkflowFilter" />
-        <label for="workflowName">Workflow Name</label>
-      </div>
-      <date-range-picker
-        :date-range="range"
-        :max-days="maxRetentionDays"
-        @change="setRange"
-      />
-      <v-select
-        class="status"
-        :value="status"
-        :options="statuses"
-        :on-change="setStatus"
-        :searchable="false"
-      />
+      <template v-if="filterMode === 'advanced'">
+        <div class="field query-string">
+          <input type="search" class="query-string"
+            placeholder=" "
+            key="sql-query"
+            name="queryString"
+            v-bind:value="$route.query.queryString"
+            @input="setWorkflowFilter" />
+          <label for="queryString">Query</label>
+        </div>
+      </template>
+      <template v-else>
+        <div class="field workflow-id">
+          <input type="search" class="workflow-id"
+            placeholder=" "
+            name="workflowId"
+            v-bind:value="$route.query.workflowId"
+            @input="setWorkflowFilter" />
+          <label for="workflowId">Workflow ID</label>
+        </div>
+        <div class="field workflow-name">
+          <input type="search" class="workflow-name"
+            placeholder=" "
+            name="workflowName"
+            v-bind:value="$route.query.workflowName"
+            @input="setWorkflowFilter" />
+          <label for="workflowName">Workflow Name</label>
+        </div>
+        <date-range-picker
+          :date-range="range"
+          :max-days="maxRetentionDays"
+          @change="setRange"
+        />
+        <v-select
+          class="status"
+          :value="status"
+          :options="statuses"
+          :on-change="setStatus"
+          :searchable="false"
+        />
+      </template>
+      <a class="toggle-filter" @click="toggleFilter">{{ filterMode === 'advanced' ? 'basic' : 'advanced' }}</a>
     </header>
     <section class="results"
       v-infinite-scroll="nextPage"
@@ -84,7 +98,8 @@ export default pagedGrid({
         { value: 'CONTINUED_AS_NEW', label: 'Continued As New' },
         { value: 'TIMED_OUT', label: 'Timed Out'}
       ],
-      maxRetentionDays: undefined
+      maxRetentionDays: undefined,
+      filterMode: 'basic'
     }
   },
   created() {
@@ -137,7 +152,8 @@ export default pagedGrid({
         endTime,
         status: q.status,
         workflowId: q.workflowId,
-        workflowName: q.workflowName
+        workflowName: q.workflowName,
+        queryString: q.queryString,
       }
     },
     queryOnChange() {
@@ -153,6 +169,10 @@ export default pagedGrid({
       delete q.domain
       q.nextPageToken = this.nextPageToken
 
+      if (q.queryString) {
+        return this.fetch(`/api/domain/${domain}/workflows/list`, q)
+      }
+
       return this.fetch(`/api/domain/${domain}/workflows/${state}`, q)
     }
   },
@@ -211,6 +231,14 @@ export default pagedGrid({
         }
         this.$router.replace({ query })
       }
+    },
+    toggleFilter() {
+      if (this.filterMode === 'advanced') {
+        this.filterMode = 'basic'
+        this.$route.query.queryString = ''
+      } else {
+        this.filterMode = 'advanced'
+      }
     }
   }
 })
@@ -228,6 +256,8 @@ section.workflows
       flex 1 1 auto
     .v-select
       flex 1 1 240px
+    a.toggle-filter
+      action-button()
 
   paged-grid()
 
diff --git a/package.json b/package.json
index 6a1b98c2e..bb9dc4b51 100644
--- a/package.json
+++ b/package.json
@@ -61,6 +61,7 @@
     "vue-router": "^3.0.1",
     "vue-select": "nathanboktae/vue-select#after2.4",
     "vue-split-panel": "^1.0.4",
+    "vue-style-loader": "^3.1.2",
     "vue-template-compiler": "^2.5.2",
     "webpack": "^3.10.0"
   },
@@ -72,6 +73,7 @@
     "mocha": "^4.0.1",
     "mocha-chrome": "^1.1.0",
     "nathanboktae-browser-test-utils": "^0.1.0",
-    "supertest": "^3.0.0"
+    "supertest": "^3.0.0",
+    "webpack-hot-client": "^1.3.0"
   }
 }
diff --git a/server/middleware/tchannel-client.js b/server/middleware/tchannel-client.js
index 887b27ef6..75d654462 100644
--- a/server/middleware/tchannel-client.js
+++ b/server/middleware/tchannel-client.js
@@ -160,6 +160,7 @@ module.exports = async function(ctx, next) {
   ctx.cadence = {
     openWorkflows: req('ListOpenWorkflowExecutions', 'list', withDomainPaging),
     closedWorkflows: req('ListClosedWorkflowExecutions', 'list', withDomainPaging),
+    listWorkflows: req('ListWorkflowExecutions', 'list', withDomainPaging),
     getHistory: req('GetWorkflowExecutionHistory', 'get', withDomainAndWorkflowExecution),
     exportHistory: req('GetWorkflowExecutionHistory', 'get', withDomainAndWorkflowExecution, cliTransform),
     describeWorkflow: req('DescribeWorkflowExecution', 'describe', withWorkflowExecution),
diff --git a/server/routes.js b/server/routes.js
index 6cdabd6f3..e4b2829e5 100644
--- a/server/routes.js
+++ b/server/routes.js
@@ -39,6 +39,14 @@ async function listWorkflows(state, ctx) {
 router.get('/api/domain/:domain/workflows/open', listWorkflows.bind(null, 'open'))
 router.get('/api/domain/:domain/workflows/closed', listWorkflows.bind(null, 'closed'))
 
+router.get('/api/domain/:domain/workflows/list', async function (ctx) {
+  var q = ctx.query || {}
+  ctx.body = await ctx.cadence['listWorkflows']({
+    query: q.queryString || undefined,
+    nextPageToken: q.nextPageToken ? Buffer.from(q.nextPageToken, 'base64') : undefined
+  })
+})
+
 router.get('/api/domain/:domain/workflows/:workflowId/:runId/history', async function (ctx) {
   var q = ctx.query || {}