Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Clarify file imports are relative to current file, more cross-linking #78

Merged
merged 1 commit into from
Aug 20, 2020
Merged

docs: Clarify file imports are relative to current file, more cross-linking #78

merged 1 commit into from
Aug 20, 2020

Conversation

francislavoie
Copy link
Member

See https://caddy.community/t/import-space-in-file-paths/9511 for the discussion where this was found to be unclear.

@francislavoie francislavoie requested a review from mholt August 19, 2020 17:21
mholt
mholt approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change. Thanks so much!

@mholt mholt merged commit f1d0d13 into caddyserver:master Aug 20, 2020
@francislavoie francislavoie deleted the clarify-import-relative branch August 20, 2020 18:10
y-yagi pushed a commit to y-yagi/website that referenced this pull request Jul 25, 2021
@ColinEberhardt
Document the behaviour of array#pop on an empty array (caddyserver#78)
0c5799e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francislavoie @mholt