Manage api from Cachet Settings page (#235) #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add settings to force authentication for API
jbrooksuk
requested changes
Feb 9, 2025
ApiEnabled & ApiPublicOrProtected which solves the early access to DB Added GetOrDefault to AppSettings for ease of use and removal of duplicate code.
jbrooksuk
requested changes
Feb 13, 2025
| { | ||
| $protected = AppSettings::getOrDefault('api_protected', false); | ||
| if ($protected) { | ||
| return parent::handle($request, $next, ...$guards); |
There was a problem hiding this comment.
This is trying to redirect to a login route which doesn't exist in Cachet.
There was a problem hiding this comment.
@jbrooksuk This is something that is managed by Sanctum.
We could override this because this is currently a global issue.
So do you want me to override the sanctum routes within the Core?
or do you want me to fix this in the Cachet repo?
Or both
Because on my instance i changed this on the cachet repo by hand (sanctum config).
So it redirect to the correct login page
Fix add static types to method
icecoldPHP
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add settings to enable and disable API
Add settings to force authentication for API
Closes: #235