Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Filipino translations (ph.json) #160

Closed

Conversation

CodeByMoriarty
Copy link
Contributor

This PR adds Filipino (Tagalog) translations to the en.json file. It includes translations for various interface texts used in the application to help Filipino-speaking users better understand the content.

@jbrooksuk
Copy link
Member

Thanks!

I'm going to put this into draft for now, while we focus on the English translations and work on the feature set. It's much harder to merge this and actively maintain it while everything else is changing.

@jbrooksuk jbrooksuk marked this pull request as draft January 2, 2025 08:09
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filename should use the iso code of the language here, which I believe should be ph.json.

@CodeByMoriarty CodeByMoriarty marked this pull request as ready for review January 2, 2025 12:21
@jbrooksuk
Copy link
Member

Thanks for the changes, @CodeByMoriarty. Still moving this to draft as I don't want to merge them too early.

@jbrooksuk jbrooksuk marked this pull request as draft January 2, 2025 13:29
@jbrooksuk jbrooksuk changed the title Add Filipino translations (fil.json) Add Filipino translations (ph.json) Jan 2, 2025
@jbrooksuk
Copy link
Member

Sorry to be a huge pain, @CodeByMoriarty, but I've just merged in #162 which converts Cachet's translations files to use short keys. I appreciate this is a pain, but:

  1. @danjohnson95 took the time to localize all strings within Cachet.
  2. Using short keys allows us to provide context to individual translations throughout the application.

I'd really appreciate your support in updating your PR 🫶

@jbrooksuk
Copy link
Member

@CodeByMoriarty are you able to convert these translations for us, please?

@CodeByMoriarty
Copy link
Contributor Author

CodeByMoriarty commented Jan 21, 2025

The one in resources/lang, right? You want me to create a copy of that in Filipino, correct?

@CodeByMoriarty CodeByMoriarty marked this pull request as ready for review January 21, 2025 15:47
@CodeByMoriarty
Copy link
Contributor Author

If you mean the resources/lang file, I can start working on it. I will send the final version as soon as possible, within one day.

@jbrooksuk
Copy link
Member

Replaced by #213

@jbrooksuk jbrooksuk closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants