Combine translator

Author: haochengxia

docs/src/en/getting_started/quickstart.md

@@ -109,7 +109,7 @@ Here is an example demonstrating how to use `TraceAnalyzer`.
     # Step 1: Get one trace from S3 bucket
     URI = "s3://cache-datasets/cache_dataset_oracleGeneral/2007_msr/msr_hm_0.oracleGeneral.zst"
     reader = lcs.TraceReader(
-        trace = dl.get_cache_path(URI),
+        trace = URI,
         trace_type = lcs.TraceType.ORACLE_GENERAL_TRACE,
         reader_init_params = lcs.ReaderInitParam(ignore_obj_size=False)
     )
@@ -140,10 +140,10 @@ Here is an example demonstrating how to use `TraceAnalyzer`.
 The above code demonstrates how to perform trace analysis using `libcachesim`. The workflow is as follows:
 
 1. Open the trace file with `TraceReader`, specifying the trace type and any reader initialization parameters. The URI starting with `s3://`, will download a trace file from an S3 bucket.
-3. Configure the analysis options with `AnalysisOption` to enable or disable specific analyses (such as request rate, size, etc.).
-4. Optionally, set additional analysis parameters with `AnalysisParam`.
-5. Create a `TraceAnalyzer` object with the reader, output directory, and the chosen options and parameters.
-6. Run the analysis with `analyzer.run()`.
+2. Configure the analysis options with `AnalysisOption` to enable or disable specific analyses (such as request rate, size, etc.).
+3. Optionally, set additional analysis parameters with `AnalysisParam`.
+4. Create a `TraceAnalyzer` object with the reader, output directory, and the chosen options and parameters.
+5. Run the analysis with `analyzer.run()`.
 
 After running, you can access the analysis results, such as summary statistics (`stat`) or detailed results (e.g., `example_analysis.size`).
 

src/exception.cpp

@@ -17,36 +17,41 @@ void register_exception(py::module& m) {
   static py::exception<CacheException> exc_cache(m, "CacheException");
   static py::exception<ReaderException> exc_reader(m, "ReaderException");
 
+  // Single exception translator with catch blocks ordered from most-specific to least-specific
   py::register_exception_translator([](std::exception_ptr p) {
     try {
       if (p) std::rethrow_exception(p);
     } catch (const CacheException& e) {
+      // Custom exception: CacheException
       py::set_error(exc_cache, e.what());
     } catch (const ReaderException& e) {
+      // Custom exception: ReaderException
       py::set_error(exc_reader, e.what());
-    }
-  });
-
-  py::register_exception_translator([](std::exception_ptr p) {
-    try {
-      if (p) std::rethrow_exception(p);
     } catch (const std::bad_alloc& e) {
+      // Memory allocation error
       PyErr_SetString(PyExc_MemoryError, e.what());
     } catch (const std::invalid_argument& e) {
+      // Invalid argument error
       PyErr_SetString(PyExc_ValueError, e.what());
     } catch (const std::out_of_range& e) {
+      // Out of range error
       PyErr_SetString(PyExc_IndexError, e.what());
     } catch (const std::domain_error& e) {
+      // Domain error
       PyErr_SetString(PyExc_ValueError,
                       ("Domain error: " + std::string(e.what())).c_str());
     } catch (const std::overflow_error& e) {
+      // Overflow error
       PyErr_SetString(PyExc_OverflowError, e.what());
     } catch (const std::range_error& e) {
+      // Range error
       PyErr_SetString(PyExc_ValueError,
                       ("Range error: " + std::string(e.what())).c_str());
     } catch (const std::runtime_error& e) {
+      // Generic runtime error
       PyErr_SetString(PyExc_RuntimeError, e.what());
     } catch (const std::exception& e) {
+      // Catch-all for any other std::exception
       PyErr_SetString(PyExc_RuntimeError,
                       ("C++ exception: " + std::string(e.what())).c_str());
     }