video.js version 5 compatibility pending?

[tweed]

Thank you greatly for the superb look - videojs-sublime-skin is a sensation with version 4.

Although new to video.js I'm enjoying the responsive features in video.js v5 -- and, although i hesitated before writing here, and also considered having a go at deducing how to mod/merge etc. to get videojs-sublime-skin to work with video.js v5, a bit of a play-around and I became kinda certain I'd ultimately fail.

So, here I am asking if/when it may b4 possible to have videojs-sublime-skin work with video.js v5?

in absolutely any event thank you very much!

[zakj]

Thanks for the kind words! I haven't been following the development of video.js v5, so I'm not sure how much work would go into updating this skin. I'd be happy to review a PR but I can't promise I'll have time to spare on a major effort in the near future.

[zanechua]

I have actually managed to complete one that works for version 5, however I don't think it has backward compatibility with version 4.

Do you still want me to do a PR?

Here's the codepen for version 5.
http://codepen.io/zanechua/pen/GozrNe

[commonpike]

That version seems to be pretty perfect as far as I can see !

Almost. It's pretty perfect at 10px. Increase the font size and the controls get out of line.

I bumped into this because I accidently loaded the stylesheet twice, causing IE to apply rules like font-size:1.8em twice on the same element (causing font-size to be 3.24em .. this seems like an ie bug).