Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow only one way for importing Gherkin file into tests #77

Open
hauleth opened this issue Feb 28, 2019 · 5 comments
Open

Allow only one way for importing Gherkin file into tests #77

hauleth opened this issue Feb 28, 2019 · 5 comments

Comments

@hauleth
Copy link
Contributor

hauleth commented Feb 28, 2019

IMHO such case should be disallowed, and for defining "helper modules" there should be separate module that would define def* macros.

@hauleth
Copy link
Contributor Author

hauleth commented Feb 28, 2019

Ok, I found that it makes sense. But alternatively I would suggest using only one way to import Gherkin file.

@hauleth hauleth changed the title Is there any sense to allow compilation of Cabbage.Feature without providing :file? Allow only one way for importing Gherkin file into tests Feb 28, 2019
@revati
Copy link
Collaborator

revati commented Feb 28, 2019

Yes it is walid case to have cabbage feature without specified feature file.

But are there multiple ways to import gherkin files? 🤔

@hauleth
Copy link
Contributor Author

hauleth commented Feb 28, 2019

Ok, I have read the code wrongly. But anyway, I would disallow such case and instead force user to always define :file in use, and instead provide separate module with DSL macros.

@revati
Copy link
Collaborator

revati commented Feb 28, 2019

Something like Cabbage.Feature and Cabbage.AbstractFeature?

While I see a benefit to it, it is more like nice to have feature, not must have, it as well might be a 1.1 release, with an extended feature.

Currently, my priority is getting 1.0 out.

And I have too few hours in week I can spend on it :(

@hauleth
Copy link
Contributor Author

hauleth commented Mar 1, 2019

Quick and dirty example how it could work Watermelon.Case and complementary Watermelon.DSL. Example usage of "external step definitions".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants