MINOR: add inserted_at column to trades #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
c9s
changed the title
c9s
reviewed
May 31, 2024
| @@ -0,0 +1,11 @@ | |||
| -- +up | |||
| -- +begin | |||
| ALTER TABLE `trades` ADD COLUMN `inserted_at` TIMESTAMP DEFAULT CURRENT_TIMESTAMP NOT NULL; | |||
c9s
reviewed
May 31, 2024
pkg/types/trade.go
Outdated
| @@ -95,6 +95,8 @@ type Trade struct { | |||
|
|
|||
| // PnL is the profit and loss value of the executed trade | |||
| PnL sql.NullFloat64 `json:"pnl" db:"pnl"` | |||
|
|
|||
| InsertedAt time.Time `db:"inserted_at"` | |||
There was a problem hiding this comment.
you can use types.Time here, it handles the datetime scan from db
ycdesu
force-pushed
the
minor/add-inserted-at-to-trade
branch
2 times, most recently
from
7cbfe7c
to
8b1a0b5
Compare
c9s
approved these changes
Jun 1, 2024
c9s
changed the title
ycdesu
force-pushed
the
minor/add-inserted-at-to-trade
branch
from
e7b4abe
to
bd5e156
Compare
ycdesu
force-pushed
the
minor/add-inserted-at-to-trade
branch
from
bd5e156
to
9ca225d
Compare
c9s
reviewed
Jun 4, 2024
pkg/types/trade.go
Outdated
| @@ -95,6 +95,8 @@ type Trade struct { | |||
|
|
|||
| // PnL is the profit and loss value of the executed trade | |||
| PnL sql.NullFloat64 `json:"pnl" db:"pnl"` | |||
|
|
|||
| InsertedAt Time `db:"inserted_at"` | |||
There was a problem hiding this comment.
@c9s It's not returned by the server. The value is generated by mysql. Do we still have to add json tag?
There was a problem hiding this comment.
yeah we have some api renders the trade object in JSON format, but it's optional, not a problem
c9s
approved these changes
Jun 6, 2024
|
好像還是 test fail 可能要 rebase 一下 我猜可能是 bitget test failed |
A trade may be missed initially and fetched after it has occurred.
ycdesu
force-pushed
the
minor/add-inserted-at-to-trade
branch
from
9ca225d
to
49d567c
Compare
c9s
approved these changes
Jun 17, 2024
|
@ycdesu you need to sign CLA~ thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A trade may be missed initially and fetched after it has occurred, so we add inserted_at column.