Migrated CRON handlers to flask. (google#1976)

Author: iamarshsingh

src/appengine/handlers/cron/backup.py

@@ -24,8 +24,8 @@
 
 from base import utils
 from config import local_config
-from handlers import base_handler
-from libs import handler
+from handlers import base_handler_flask
+from libs import handler_flask
 from metrics import logs
 
 # CrashStatistic is excluded because the number of records is too high and
@@ -38,17 +38,17 @@ def _datastore_client():
   return googleapiclient.discovery.build('datastore', 'v1')
 
 
-class Handler(base_handler.Handler):
+class Handler(base_handler_flask.Handler):
   """Handler for triggering the backup URL."""
 
-  @handler.check_cron()
+  @handler_flask.cron()
   def get(self):
     """Handle a cron job."""
     backup_bucket = local_config.Config(
         local_config.PROJECT_PATH).get('backup.bucket')
     if not backup_bucket:
       logs.log('No backup bucket is set, skipping.')
-      return
+      return 'OK'
 
     kinds = [
         kind for kind in ndb.Model._kind_map  # pylint: disable=protected-access
@@ -80,6 +80,4 @@ def get(self):
       status_code = e.resp.status
       logs.log_error(message, error=str(e))
 
-    self.response.headers['Content-Type'] = 'text/plain'
-    self.response.out.write(message)
-    self.response.set_status(status_code)
+    return (message, status_code, {'Content-Type': 'text/plain'})

src/appengine/handlers/cron/batch_fuzzer_jobs.py

@@ -14,8 +14,8 @@
 """A cron handler that batches FuzzerJobs."""
 
 from datastore import data_types
-from handlers import base_handler
-from libs import handler
+from handlers import base_handler_flask
+from libs import handler_flask
 
 from google.cloud import ndb
 
@@ -56,10 +56,10 @@ def batch_fuzzer_jobs():
       ndb.delete_multi(batches_to_remove)
 
 
-class Handler(base_handler.Handler):
+class Handler(base_handler_flask.Handler):
   """Handler for building data_types.CrashsStats2."""
 
-  @handler.check_cron()
+  @handler_flask.cron()
   def get(self):
     """Process a GET request from a cronjob."""
     batch_fuzzer_jobs()

src/appengine/handlers/cron/build_crash_stats.py

@@ -34,8 +34,8 @@
 from base import utils
 from datastore import data_types
 from google_cloud_utils import big_query
-from handlers import base_handler
-from libs import handler
+from handlers import base_handler_flask
+from libs import handler_flask
 from metrics import crash_stats
 
 # After insertion, it takes a few seconds for a record to show up.
@@ -174,14 +174,11 @@ def build_if_needed():
     logging.info("Skip building crash stats because it's too early.")
 
 
-class Handler(base_handler.Handler):
+class Handler(base_handler_flask.Handler):
   """Handler for building data_types.CrashsStats2."""
 
-  @handler.check_cron()
+  @handler_flask.cron()
   def get(self):
     """Process a GET request from a cronjob."""
     end_hour = build_if_needed()
-
-    self.response.headers['Content-Type'] = 'text/plain'
-    self.response.out.write('OK (end_hour=%s)' % end_hour)
-    self.response.set_status(200)
+    return 'OK (end_hour=%s)' % end_hour

src/appengine/handlers/cron/cleanup.py

@@ -31,8 +31,8 @@
 from datastore import data_types
 from datastore import ndb_utils
 from fuzzing import leak_blacklist
-from handlers import base_handler
-from libs import handler
+from handlers import base_handler_flask
+from libs import handler_flask
 from libs import mail
 from libs.issue_management import issue_filer
 from libs.issue_management import issue_tracker_policy
@@ -1239,10 +1239,10 @@ def cleanup_unused_heartbeats():
   ndb_utils.delete_multi(unused_heartbeats)
 
 
-class Handler(base_handler.Handler):
+class Handler(base_handler_flask.Handler):
   """Cleanup."""
 
-  @handler.check_cron()
+  @handler_flask.cron()
   def get(self):
     cleanup_testcases_and_issues()
     cleanup_reports_metadata()

src/appengine/handlers/cron/corpus_backup.py

@@ -22,8 +22,8 @@
 from datastore import ndb_utils
 from fuzzing import corpus_manager
 from google_cloud_utils import storage
-from handlers import base_handler
-from libs import handler
+from handlers import base_handler_flask
+from libs import handler_flask
 from metrics import logs
 
 
@@ -74,10 +74,10 @@ def _make_corpus_backup_public(target, corpus_fuzzer_name_override,
   logs.log('Corpus backup %s is now marked public.' % corpus_backup_url)
 
 
-class MakePublicHandler(base_handler.Handler):
+class MakePublicHandler(base_handler_flask.Handler):
   """Makes corpuses older than 90 days public."""
 
-  @handler.check_cron()
+  @handler_flask.cron()
   def get(self):
     """Handle a GET request."""
     jobs = ndb_utils.get_all_from_model(data_types.Job)

src/appengine/handlers/cron/fuzz_strategy_selection.py

@@ -27,8 +27,8 @@
 from datastore import ndb_utils
 from fuzzing import strategy
 from google_cloud_utils import big_query
-from handlers import base_handler
-from libs import handler
+from handlers import base_handler_flask
+from libs import handler_flask
 from metrics import logs
 
 # After experimentation with high, low, and medium temperature parameters, we
@@ -205,13 +205,13 @@ def _query_and_upload_strategy_probabilities(engine):
       engine.name))
 
 
-class Handler(base_handler.Handler):
+class Handler(base_handler_flask.Handler):
   """Cron job handler for fuzz strategy selection.
 
   Handler to periodically update fuzz strategy bandit probabilities
   based on a performance metric (currently based on new_edges)."""
 
-  @handler.check_cron()
+  @handler_flask.cron()
   def get(self):
     """Process all fuzz targets and update FuzzStrategy weights."""
     for engine in ENGINE_LIST:

src/appengine/handlers/cron/fuzzer_and_job_weights.py

@@ -24,8 +24,8 @@
 from datastore import data_types
 from datastore import ndb_utils
 from google_cloud_utils import big_query
-from handlers import base_handler
-from libs import handler
+from handlers import base_handler_flask
+from libs import handler_flask
 from metrics import fuzzer_stats
 from metrics import logs
 from system import environment
@@ -386,10 +386,10 @@ def update_job_weights():
     update_job_weight(job.name, multiplier)
 
 
-class Handler(base_handler.Handler):
+class Handler(base_handler_flask.Handler):
   """Handler to periodically update fuzz target weights based on performance."""
 
-  @handler.check_cron()
+  @handler_flask.cron()
   def get(self):
     """Process all fuzz targets and update FuzzTargetJob weights."""
     client = big_query.Client()

src/appengine/handlers/cron/fuzzer_coverage.py

@@ -23,8 +23,8 @@
 from datastore import data_types
 from datastore import ndb_utils
 from google_cloud_utils import storage
-from handlers import base_handler
-from libs import handler
+from handlers import base_handler_flask
+from libs import handler_flask
 from metrics import logs
 
 
@@ -134,10 +134,10 @@ def collect_fuzzer_coverage(bucket):
     _process_project(project, bucket)
 
 
-class Handler(base_handler.Handler):
+class Handler(base_handler_flask.Handler):
   """Collects the latest code coverage stats and links to reports."""
 
-  @handler.check_cron()
+  @handler_flask.cron()
   def get(self):
     """Handle a GET request."""
     # The task is supposed to be super reliable and never fail. If anything goes

src/appengine/handlers/cron/load_bigquery_stats.py

@@ -24,8 +24,8 @@
 from base import utils
 from datastore import data_types
 from google_cloud_utils import big_query
-from handlers import base_handler
-from libs import handler
+from handlers import base_handler_flask
+from libs import handler_flask
 from metrics import fuzzer_stats
 from metrics import fuzzer_stats_schema
 from metrics import logs
@@ -36,7 +36,7 @@
 RETRY_SLEEP_TIME = 5
 
 
-class Handler(base_handler.Handler):
+class Handler(base_handler_flask.Handler):
   """Cron handler for loading bigquery stats."""
 
   def _utc_now(self):
@@ -150,7 +150,7 @@ def _load_data(self, bigquery, fuzzer):
       # See https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs/query.
       logs.log('Response from BigQuery: %s' % response)
 
-  @handler.check_cron()
+  @handler_flask.cron()
   def get(self):
     """Load bigquery stats from GCS."""
     if not big_query.get_bucket():

src/appengine/handlers/cron/manage_vms.py

@@ -33,9 +33,9 @@
 from datastore import data_types
 from datastore import ndb_utils
 from google_cloud_utils import compute_engine_projects
-from handlers import base_handler
+from handlers import base_handler_flask
 from handlers.cron.helpers import bot_manager
-from libs import handler
+from libs import handler_flask
 
 PROJECT_MIN_CPUS = 1
 
@@ -698,10 +698,10 @@ def assign_hosts_to_workers(self):
     self.cleanup_old_assignments(all_host_names)
 
 
-class Handler(base_handler.Handler):
+class Handler(base_handler_flask.Handler):
   """CPU distributor for OSS-Fuzz projects."""
 
-  @handler.check_cron()
+  @handler_flask.cron()
   def get(self):
     """Handle a get request."""
     if utils.is_oss_fuzz():