-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed isWithinBar() crash when there were less than 2 items in pathSe… #2652
Conversation
658330d
to
033a2e2
Compare
Codecov Report
@@ Coverage Diff @@
## master #2652 +/- ##
==========================================
- Coverage 80.14% 80.13% -0.02%
==========================================
Files 57 57
Lines 4518 4520 +2
==========================================
+ Hits 3621 3622 +1
- Misses 897 898 +1
Continue to review full report at Codecov.
|
3 similar comments
Codecov Report
@@ Coverage Diff @@
## master #2652 +/- ##
==========================================
- Coverage 80.14% 80.13% -0.02%
==========================================
Files 57 57
Lines 4518 4520 +2
==========================================
+ Hits 3621 3622 +1
- Misses 897 898 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2652 +/- ##
==========================================
- Coverage 80.14% 80.13% -0.02%
==========================================
Files 57 57
Lines 4518 4520 +2
==========================================
+ Hits 3621 3622 +1
- Misses 897 898 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2652 +/- ##
==========================================
- Coverage 80.14% 80.13% -0.02%
==========================================
Files 57 57
Lines 4518 4520 +2
==========================================
+ Hits 3621 3622 +1
- Misses 897 898 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@panthony LGTM. Thanks!
Rebased version of #1550
I'm using c3js within a webapp based on Ember and it can happen that charts are drawn &
destroyed even before they finish loading.
When navigating I can often have the following error happening: