Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed isWithinBar() crash when there were less than 2 items in pathSe… #2652

Merged
merged 1 commit into from
Jul 29, 2019

Conversation

panthony
Copy link
Contributor

Rebased version of #1550

I'm using c3js within a webapp based on Ember and it can happen that charts are drawn &
destroyed even before they finish loading.

When navigating I can often have the following error happening:

Capture d’écran 2019-07-26 à 11 16 47

@panthony panthony added C-bug Category: This is a bug and removed C-bug Category: This is a bug labels Jul 26, 2019
@codecov-io
Copy link

Codecov Report

Merging #2652 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2652      +/-   ##
==========================================
- Coverage   80.14%   80.13%   -0.02%     
==========================================
  Files          57       57              
  Lines        4518     4520       +2     
==========================================
+ Hits         3621     3622       +1     
- Misses        897      898       +1
Impacted Files Coverage Δ
src/shape.bar.js 98.64% <50%> (-1.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4643f4f...033a2e2. Read the comment docs.

3 similar comments
@codecov-io
Copy link

Codecov Report

Merging #2652 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2652      +/-   ##
==========================================
- Coverage   80.14%   80.13%   -0.02%     
==========================================
  Files          57       57              
  Lines        4518     4520       +2     
==========================================
+ Hits         3621     3622       +1     
- Misses        897      898       +1
Impacted Files Coverage Δ
src/shape.bar.js 98.64% <50%> (-1.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4643f4f...033a2e2. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #2652 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2652      +/-   ##
==========================================
- Coverage   80.14%   80.13%   -0.02%     
==========================================
  Files          57       57              
  Lines        4518     4520       +2     
==========================================
+ Hits         3621     3622       +1     
- Misses        897      898       +1
Impacted Files Coverage Δ
src/shape.bar.js 98.64% <50%> (-1.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4643f4f...033a2e2. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Jul 26, 2019

Codecov Report

Merging #2652 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2652      +/-   ##
==========================================
- Coverage   80.14%   80.13%   -0.02%     
==========================================
  Files          57       57              
  Lines        4518     4520       +2     
==========================================
+ Hits         3621     3622       +1     
- Misses        897      898       +1
Impacted Files Coverage Δ
src/shape.bar.js 98.64% <50%> (-1.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4643f4f...033a2e2. Read the comment docs.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panthony LGTM. Thanks!

@kt3k kt3k merged commit c0a08f1 into c3js:master Jul 29, 2019
@panthony panthony deleted the fix/is-within-bar branch August 7, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants