udf: add assertions

jankara · Linus Torvalds · commit 948b9b2c967c · 2007-05-08T11:15:21.000-07:00
Add a few assertions into udf_discard_prealloc() to check that the file is
sane (mostly helps debugging further patches ;).

Signed-off-by: Jan Kara &lt;jack@suse.cz&gt;
Acked-by: Christoph Hellwig &lt;hch@infradead.org&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
diff --git a/fs/udf/truncate.c b/fs/udf/truncate.c
@@ -88,8 +88,9 @@ void udf_discard_prealloc(struct inode * inode)
 	{
 		etype = netype;
 		lbcount += elen;
-		if (lbcount > inode->i_size && lbcount - inode->i_size < inode->i_sb->s_blocksize)
+		if (lbcount > inode->i_size && lbcount - elen < inode->i_size)
 		{
+			WARN_ON(lbcount - inode->i_size >= inode->i_sb->s_blocksize);
 			nelen = elen - (lbcount - inode->i_size);
 			epos.offset -= adsize;
 			extent_trunc(inode, &epos, eloc, etype, elen, nelen);
@@ -119,6 +120,7 @@ void udf_discard_prealloc(struct inode * inode)
 	}
 	UDF_I_LENEXTENTS(inode) = lbcount;
 
+	WARN_ON(lbcount != inode->i_size);
 	brelse(epos.bh);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -88,8 +88,9 @@ void udf_discard_prealloc(struct inode * inode)`
`88`	`88`	`{`
`89`	`89`	`etype = netype;`
`90`	`90`	`lbcount += elen;`
`91`		`- if (lbcount > inode->i_size && lbcount - inode->i_size < inode->i_sb->s_blocksize)`
	`91`	`+ if (lbcount > inode->i_size && lbcount - elen < inode->i_size)`
`92`	`92`	`{`
	`93`	`+ WARN_ON(lbcount - inode->i_size >= inode->i_sb->s_blocksize);`
`93`	`94`	`nelen = elen - (lbcount - inode->i_size);`
`94`	`95`	`epos.offset -= adsize;`
`95`	`96`	`extent_trunc(inode, &epos, eloc, etype, elen, nelen);`
`@@ -119,6 +120,7 @@ void udf_discard_prealloc(struct inode * inode)`
`119`	`120`	`}`
`120`	`121`	`UDF_I_LENEXTENTS(inode) = lbcount;`
`121`	`122`
	`123`	`+ WARN_ON(lbcount != inode->i_size);`
`122`	`124`	`brelse(epos.bh);`
`123`	`125`	`}`
`124`	`126`