Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky-Tests at local runs (Mac) #148

Open
Chris53897 opened this issue May 11, 2023 · 3 comments
Open

Flaky-Tests at local runs (Mac) #148

Chris53897 opened this issue May 11, 2023 · 3 comments

Comments

@Chris53897
Copy link

Chris53897 commented May 11, 2023

The following test are flaky at my local Mac M1 OS 13.3.1, php 8.2.6. They look stable in CI.

testBadWrite()
testMultiWrite()
testReadContents()

@bzikarsky
Copy link
Owner

Can you narrow it down a bit? Is it opening sockets? I assume all of these are from the TCP testsuite?

@Chris53897
Copy link
Author

I did multiple changes in #150 that helps pretty much.
Before: 5 failing run, and one green
With the PR: 5 sucessfull runs, and than a failing one

The stream_copy_to_stream often fails. I do not why
https://github.com/bzikarsky/gelf-php/blob/master/tests/Gelf/Test/Transport/StreamSocketClientTcpTest.php#L130

self::assertEquals(strlen($testData), stream_copy_to_stream($connection, $connection, strlen($testData)));

Failed asserting that false matches expected 80.
Expected :80
Actual :false

Failed asserting that false matches expected 80.
Expected :15
Actual :false

@Chris53897 Chris53897 changed the title Flaky-Tests at local runs Flaky-Tests at local runs (Mac) May 12, 2023
@Chris53897
Copy link
Author

Can somebody confirm this behaviour? Just to make sure, that it is not just my system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants