Skip to content

Commit

Permalink
Revert "Cancel incomplete BLE connection when CloseAllBleConnections(…
Browse files Browse the repository at this point in the history
…) is called (project-chip#27304)"

This reverts commit ad5403e.

There are two issues:

* project-chip#27607 which has had no
  response for weeks.
* project-chip#28139 which breaks
  commissioning on Mac, and would break it on Linux if it implemented BLE
  connection cancellation.

We need to sort out why CHIPDeviceController is canceling BLE connections when
starting PASE over BLE (!).
  • Loading branch information
bzbarsky-apple committed Jul 21, 2023
1 parent d0f14e0 commit a44823b
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions src/ble/BleLayer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -308,13 +308,6 @@ void BleLayer::Shutdown()

void BleLayer::CloseAllBleConnections()
{
// Cancel any ongoing attempt to establish new BLE connection
CHIP_ERROR err = CancelBleIncompleteConnection();
if (err != CHIP_NO_ERROR)
{
ChipLogError(Ble, "CancelBleIncompleteConnection() failed, err = %" CHIP_ERROR_FORMAT, err.Format());
}

// Close and free all BLE end points.
for (size_t i = 0; i < BLE_LAYER_NUM_BLE_ENDPOINTS; i++)
{
Expand Down

0 comments on commit a44823b

Please sign in to comment.