[BitSail][Common] Support type definition case independent #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
healchow
reviewed
Jan 15, 2023
hk-lrzy
reviewed
Jan 16, 2023
| } | ||
|
|
||
| toTypeInformation.put(entry.getKey(), customTypeInfo); | ||
| toTypeInformation.put(StringUtils.lowerCase(entry.getKey()), customTypeInfo); |
There was a problem hiding this comment.
This will influence the logic in the class FileMappingTypeInfoConverter and it's subclass, plz add more test for this one.
There was a problem hiding this comment.
Thank you for your suggestion. I will add more tests later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by:
Pre-Checklist
Note: Please complete ALL items in the following checklist.
Purpose
Some description about what this PR wants to do.
Approaches
Some description about how this PR achives the purpose.
Related Issues
Close #327
New Behavior (screenshots if needed)
N/A