Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement serde::Deserialize for wit-bindgen-rust::Opts #1244

Merged
merged 4 commits into from
Mar 26, 2025
Merged

Implement serde::Deserialize for wit-bindgen-rust::Opts #1244

merged 4 commits into from
Mar 26, 2025
+29 −2

Conversation

justingaffney
Copy link
Contributor

To allow deserialisation of bindgen options, for example from Cargo package metadata like in bytecodealliance/cargo-component#384

alexcrichton
alexcrichton reviewed Mar 25, 2025
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Mind making this an optional dependency to avoid adding extra build time to existing deps?

@justingaffney
Copy link
Contributor Author

Yep it should be good now

@alexcrichton alexcrichton added this pull request to the merge queue Mar 26, 2025
Merged via the queue into bytecodealliance:main with commit 5274c27 Mar 26, 2025
18 checks passed
@justingaffney justingaffney deleted the deserialize_impl branch March 26, 2025 23:31
@justingaffney justingaffney mentioned this pull request Mar 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justingaffney @alexcrichton