[Rust] use cleanup list as necessary for stream/future writes #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
approved these changes
Mar 24, 2025
Previously, I had failed to consider (or test) the case where lowering values for stream/future writes would require intermediate allocations that need to be cleaned up. That manifested as compiler errors due to generated code referencing a non-existent `cleanup_list` variable. Fixes bytecodealliance#1153 Signed-off-by: Joel Dice <joel.dice@fermyon.com>
dicej
force-pushed
the
stream-future-write-cleanup-list
branch
from
20b46dc to
b9069bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, I had failed to consider (or test) the case where lowering values for stream/future writes would require intermediate allocations that need to be cleaned up. That manifested as compiler errors due to generated code referencing a non-existent
cleanup_listvariable.Fixes #1153