Migrate the rust_xcrate test to wit-bindgen test
#1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
jsturtevant
reviewed
Mar 21, 2025
| @@ -0,0 +1,75 @@ | |||
| //@ tests = ['intermediate', 'leaf'] | |||
There was a problem hiding this comment.
does this mean runner is run with both intermediate and leaf?
There was a problem hiding this comment.
Good question, and mostly points to this being a bad name. I've renamed this to dependencies which should make it more clear that these are dependencies of the runner component, not separate and individual tests. The sum total of all three components are what makes a single test.
pchickey
approved these changes
Mar 24, 2025
jsturtevant
approved these changes
Mar 24, 2025
This was a tricky test to migrate. Doing this required implementing a number of new features: * Rust now has a `[lang]`-specific configuration `externs = [...]` which is a list of files to compile as external crates. This tests the cross-crate behavior of the test. * Tests now support more than just runner/test composed components, now they also support multiple components being composed. This is required because the test was specifically testing behavior where a component simultaneously imports and exports. This last point was particularly tricky. Namely this required abstracting the definition of a test to a runner plus a list of tests, not just one test. These are still modeled as a list of `world` items in the original WIT document. Additionally I was having trouble getting `wasm-compose` working so I ended up switching to `wac`. This means that tests can now support custom `wac` composition scripts to configure how exactly the composition is created, and that's used in this new test to insert a component as a sandwich between two others.
alexcrichton
force-pushed
the
migrate-xcrate
branch
from
373efc8 to
ff0ad4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a tricky test to migrate. Doing this required implementing a number of new features:
[lang]-specific configurationexterns = [...]which is a list of files to compile as external crates. This tests the cross-crate behavior of the test.This last point was particularly tricky. Namely this required abstracting the definition of a test to a runner plus a list of tests, not just one test. These are still modeled as a list of
worlditems in the original WIT document. Additionally I was having trouble gettingwasm-composeworking so I ended up switching towac. This means that tests can now support customwaccomposition scripts to configure how exactly the composition is created, and that's used in this new test to insert a component as a sandwich between two others.