Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let WasmTy differentiate between passing ownership into Wasm vs a borrow #2056

Open
fitzgen opened this issue Jul 21, 2020 · 1 comment
Open
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself

Comments

@fitzgen
Copy link
Member

fitzgen commented Jul 21, 2020

Only matters for reference types. But if we know the call is borrowing a reference type that will outlive the call, we don't need to add it into the activations table because the borrow checker already ensures it will live long enough.

Currently only Func::{wrap,get} will pass by value (and therefore need the activations table) while Func::call will pass borrows (and therefore we know the reference will outlive the call, and it doesn't need to go into the table).

See also bytecodealliance/wasmtime-dotnet#27 (comment)

@alexcrichton alexcrichton added the wasmtime:api Related to the API of the `wasmtime` crate itself label May 5, 2022
@github-actions
Copy link

github-actions bot commented May 5, 2022

Subscribe to Label Action

cc @peterhuene

This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself
Projects
None yet
Development

No branches or pull requests

2 participants