Clean up the diff

Author: elliottt

crates/wasi-http/src/types.rs

@@ -333,9 +333,6 @@ pub enum HostFields {
         // always be registered as a child of the entry with the `parent` id. This ensures that the
         // entry will always exist while this `HostFields::Ref` entry exists in the table, thus we
         // don't need to account for failure when fetching the fields ref from the parent.
-        //
-        // NOTE: references are always considered immutable -- the only way to modify fields is to
-        // create an owned version first.
         get_fields: for<'a> fn(elem: &'a mut (dyn Any + 'static)) -> &'a mut FieldMap,
     },
     Owned {

crates/wasi-http/src/types_impl.rs

@@ -20,18 +20,15 @@ use wasmtime_wasi::preview2::{
 impl<T: WasiHttpView> crate::bindings::http::types::Host for T {}
 
 /// Take ownership of the underlying [`FieldMap`] associated with this fields resource. If the
-/// fields resource references another fields, the returned [`FieldMap`] will be cloned. We throw
-/// away the `immutable` status of the original fields, as the new context will determine how the
-/// [`FieldMap`] is used.
+/// fields resource references another fields, the returned [`FieldMap`] will be cloned.
 fn move_fields(table: &mut Table, id: Resource<HostFields>) -> wasmtime::Result<FieldMap> {
     match table.delete(id)? {
         HostFields::Ref { parent, get_fields } => {
             let entry = table.get_any_mut(parent)?;
-            let fields = get_fields(entry);
-            Ok(fields.clone())
+            Ok(get_fields(entry).clone())
         }
 
-        HostFields::Owned { fields, .. } => Ok(fields),
+        HostFields::Owned { fields } => Ok(fields),
     }
 }