Skip to content

Commit 2ba3d6e

Browse files
committed
Pin an older nightly to fix wasi tests
Rust's recent update to libstd of the wasm32-wasi target turned out to be buggy with respect to fetching the process arguments, so we'll need to wait on a fix there before we can run these tests with nightly again.
1 parent 3558d41 commit 2ba3d6e

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

.github/actions/install-rust/main.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,13 @@
11
const child_process = require('child_process');
22
const toolchain = process.env.INPUT_TOOLCHAIN;
33

4-
for (var i = 0, keys = Object.keys(process.env), ii = keys.length; i < ii; i++) {
5-
console.log(keys[i] + '=' + process.env[keys[i]]);
6-
}
7-
84
if (process.platform === 'darwin') {
95
child_process.execSync(`curl https://sh.rustup.rs | sh -s -- -y --default-toolchain=none --profile=minimal`);
106
const bindir = `${process.env.HOME}/.cargo/bin`;
117
console.log(`::add-path::${bindir}`);
128
process.env.PATH = `${process.env.PATH}:${bindir}`;
13-
child_process.execFileSync('rustup', ['set', 'profile', 'minimal']);
149
}
1510

11+
child_process.execFileSync('rustup', ['set', 'profile', 'minimal']);
1612
child_process.execFileSync('rustup', ['update', toolchain, '--no-self-update']);
1713
child_process.execFileSync('rustup', ['default', toolchain]);

.github/workflows/main.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,11 @@ jobs:
102102
- build: beta
103103
os: ubuntu-latest
104104
rust: beta
105+
# FIXME need to wait for rust's libstd for wasi to get fixed, and then
106+
# this can be updated to `nightly` again.
105107
- build: nightly
106108
os: ubuntu-latest
107-
rust: nightly
109+
rust: nightly-2019-12-04
108110
- build: macos
109111
os: macos-latest
110112
rust: stable

0 commit comments

Comments
 (0)