Review comments

Author: saulecabrera

Gemfile.lock

@@ -2,7 +2,7 @@ PATH
   remote: .
   specs:
     wasmtime (19.0.0)
-      rb_sys (~> 0.9.86)
+      rb_sys (~> 0.9.97)
 
 GEM
   remote: https://rubygems.org/

ext/src/ruby_api/convert.rs

@@ -127,11 +127,11 @@ impl ToExtern for Value {
 }
 
 pub trait ToSym {
-    fn as_sym(&self) -> Result<Symbol, Error>;
+    fn to_sym(&self) -> Result<Symbol, Error>;
 }
 
 impl ToSym for ValType {
-    fn as_sym(&self) -> Result<Symbol, Error> {
+    fn to_sym(&self) -> Result<Symbol, Error> {
         if self.matches(&ValType::EXTERNREF) {
             return Ok(Symbol::from(*EXTERNREF));
         }
@@ -152,7 +152,7 @@ impl ToSym for ValType {
 }
 
 impl ToSym for RefType {
-    fn as_sym(&self) -> Result<Symbol, Error> {
+    fn to_sym(&self) -> Result<Symbol, Error> {
         if self.matches(&RefType::FUNCREF) {
             return Ok(Symbol::from(*FUNCREF));
         }

ext/src/ruby_api/func.rs

@@ -136,8 +136,8 @@ impl<'a> Func<'a> {
         let len = ty.params().len();
         let mut params = ty.params();
         params.try_fold(RArray::with_capacity(len), |array, p| {
-            array.push(p.as_sym()?).map_err(|e| error!("{e}"))?;
-            Ok::<_, Error>(array)
+            array.push(p.to_sym()?)?;
+            Ok(array)
         })
     }
 
@@ -148,8 +148,8 @@ impl<'a> Func<'a> {
         let len = ty.results().len();
         let mut results = ty.results();
         results.try_fold(RArray::with_capacity(len), |array, r| {
-            array.push(r.as_sym()?).map_err(|e| error!("{e}"))?;
-            Ok::<_, Error>(array)
+            array.push(r.to_sym()?)?;
+            Ok(array)
         })
     }
 

ext/src/ruby_api/global.rs

@@ -95,7 +95,7 @@ impl<'a> Global<'a> {
     /// @def type
     /// @return [Symbol] The Wasm type of the global‘s content.
     pub fn type_(&self) -> Result<Symbol, Error> {
-        self.ty()?.content().as_sym()
+        self.ty()?.content().to_sym()
     }
 
     /// @yard

ext/src/ruby_api/table.rs

@@ -89,7 +89,7 @@ impl<'a> Table<'a> {
     /// @def type
     /// @return [Symbol] The Wasm type of the elements of this table.
     pub fn type_(&self) -> Result<Symbol, Error> {
-        self.ty()?.element().as_sym()
+        self.ty()?.element().to_sym()
     }
 
     /// @yard