Skip to content

Conversation

@no1wudi
Copy link
Collaborator

@no1wudi no1wudi commented Oct 26, 2021

For cmake based project, there are default values in .cmake,
but for other build system, may these symbols were not defined in their
build system and warnings (XXX is not defined) generated while buiding.

Signed-off-by: Huang Qi huangqi3@xiaomi.com

Copy link
Collaborator

@xujuntwt95329 xujuntwt95329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

For cmake based project, there are default values in .cmake,
but for other build system, may these symbols were not defined in their
build system and warnings (XXX is not defined) generated while building.

Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
@wenyongh wenyongh merged commit 51a00a4 into bytecodealliance:main Oct 26, 2021
wenyongh referenced this pull request in wenyongh/wasm-micro-runtime Oct 26, 2021
Disable source debugging by default (#804)
vickiegpt pushed a commit to vickiegpt/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
For cmake based project, there are default values in .cmake,
but for other build system, may these symbols were not defined in their
build system and warnings (XXX is not defined) were generated while building.

Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants