Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aot: make precheck functions use short-call for xtensa #3418

Merged
merged 3 commits into from
May 13, 2024

Conversation

yamt
Copy link
Collaborator

@yamt yamt commented May 13, 2024

Note: this breaks AOT ABI for xtensa again because of a revert of an ABI-breaking change.

@yamt yamt marked this pull request as ready for review May 13, 2024 01:47
@yamt
Copy link
Collaborator Author

yamt commented May 13, 2024

@dongsheng28849455 do you have any concerns?

@dongsheng28849455
Copy link
Contributor

@dongsheng28849455 do you have any concerns?

No much concerns except for the need to test more cases since the LLVM base is changed, we need do some test for that.

@wenyongh wenyongh merged commit 8f098a5 into bytecodealliance:main May 13, 2024
376 checks passed
@yamt
Copy link
Collaborator Author

yamt commented May 20, 2024

@dongsheng28849455 do you have any concerns?

No much concerns except for the need to test more cases since the LLVM base is changed, we need do some test for that.

do you have some testsuite targeting xtensa aot?

@dongsheng28849455
Copy link
Contributor

do you have some testsuite targeting xtensa aot?

we have spec/wasi test for xtensa, let's try.

@yamt
Copy link
Collaborator Author

yamt commented May 20, 2024

i did some tests on nuttx on esp32s3-devkitc.

aot xip (--xip --size-level=0)

nsh> time "iwasm --dir=. toywasm.s0.xip.aot --wasi --wasi-dir . -- toywasm.wasm
--wasi hello.wasm"
hello

24.4400 sec
nsh>

aot (--size-level=0)

nsh> time "iwasm --dir=. toywasm.s0.aot --wasi --wasi-dir . -- toywasm.wasm --wa
si hello.wasm"
hello

16.1800 sec
nsh>

classic interpreter

nsh> time "iwasm --dir=. toywasm.wasm --wasi --wasi-dir . -- toywasm.wasm --wasi
 hello.wasm"
hello

57.1700 sec
nsh> 

native

nsh> time "toywasm --wasi --wasi-dir . toywasm.wasm --wasi hello.wasm"
hello

2.7400 sec
nsh>

file sizes:

-rwxr-xr-x  1 yamamoto  staff      177 Jun 19  2023 hello.wasm*
-rw-r--r--  1 yamamoto  staff  1857100 May 20 15:31 toywasm.s0.aot
-rw-r--r--  1 yamamoto  staff  2335540 May 20 15:31 toywasm.s0.xip.aot
-rwxr-xr-x  1 yamamoto  staff   584131 May 20 15:21 toywasm.wasm*

SChina-CSC-SDD-Dev pushed a commit to SChina-CSC-SDD-Dev/wasm-micro-runtime that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants