Skip to content

Do not use pagezero size option if osx version >= 13 #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2024
Merged

Do not use pagezero size option if osx version >= 13 #3025

merged 1 commit into from
Jan 16, 2024

Conversation

@eloparco
Copy link
Contributor

Fixes #3009

@wenyongh wenyongh merged commit bb053e3 into bytecodealliance:main Jan 16, 2024
yamt
yamt reviewed Jan 16, 2024
View reviewed changes
build-scripts/config_common.cmake
endif ()

if (APPLE)
EXEC_PROGRAM(sw_vers ARGS -productVersion OUTPUT_VARIABLE OS_X_VERSION)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess we should check cmake target instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean like here? https://github.com/neovim/neovim/blob/3fef24aa01ab2223d5455e7b22d218ea91495c86/cmake.deps/CMakeLists.txt#L61-L66

@wenyongh wenyongh mentioned this pull request Jan 16, 2024
Closed
yamt added a commit to yamt/wasm-micro-runtime that referenced this pull request Jan 16, 2024
@yamt
Revert "Do not use pagezero size option if osx version >= 13 (bytecod…
418a50d 
…ealliance#3025)"

This reverts commit bb053e3.
yamt added a commit to yamt/wasm-micro-runtime that referenced this pull request Jan 17, 2024
@yamt
Revert "Do not use pagezero size option if osx version >= 13 (bytecod…
41d5bbc 
…ealliance#3025)"

This reverts commit bb053e3.
wenyongh pushed a commit that referenced this pull request Jan 18, 2024
@yamt
Revert "Enable MAP_32BIT for macOS (#2992)" (#3032)
d13a54f 
Revert "Do not use pagezero size option if osx version >= 13 (#3025)"
and  "Enable MAP_32BIT for macOS (#2992)".

Discussion: #3009
vickiegpt pushed a commit to vickiegpt/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@eloparco
Do not use pagezero size option if osx version >= 13 (bytecodeallianc…
4b2746f 
…e#3025)

Reported in bytecodealliance#3009.
vickiegpt pushed a commit to vickiegpt/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@yamt
Revert "Enable MAP_32BIT for macOS (bytecodealliance#2992)" (bytecode…
7a9f054 
…alliance#3032)

Revert "Do not use pagezero size option if osx version >= 13 (bytecodealliance#3025)"
and  "Enable MAP_32BIT for macOS (bytecodealliance#2992)".

Discussion: bytecodealliance#3009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yamt yamt yamt left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to run iwasm on MacOS after #2992

3 participants

@eloparco @yamt @wenyongh