Expose API to set log level in embedder #2907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyongh
reviewed
Dec 15, 2023
core/iwasm/include/wasm_export.h
Outdated
| wasm_runtime_full_init(RuntimeInitArgs *init_args); | ||
|
|
||
| /** | ||
| * Set the log level. To be called after the runtime is created. |
There was a problem hiding this comment.
Had better change created to initialized?
eloparco
force-pushed
the
eloparco/set-log-level-embedder
branch
from
d043de5 to
0022e87
Compare
yamt
reviewed
Dec 15, 2023
core/iwasm/include/wasm_export.h
Outdated
| BH_LOG_LEVEL_ERROR = 1, | ||
| BH_LOG_LEVEL_WARNING = 2, | ||
| BH_LOG_LEVEL_DEBUG = 3, | ||
| BH_LOG_LEVEL_VERBOSE = 4 |
There was a problem hiding this comment.
if these are for wasm_runtime_set_log_level, it seems a bit odd to use BH_ prefix. how do you think?
There was a problem hiding this comment.
How about changing to WASM_LOG_LEVEL_*? Or is there other suggestion?
There was a problem hiding this comment.
How about changing to
WASM_LOG_LEVEL_*?
it sounds better to me.
There was a problem hiding this comment.
Good to me too. @eloparco, could you help update the code? Thanks.
eloparco
force-pushed
the
eloparco/set-log-level-embedder
branch
from
0022e87 to
fb80982
Compare
wenyongh
reviewed
Dec 15, 2023
eloparco
force-pushed
the
eloparco/set-log-level-embedder
branch
3 times, most recently
from
64a4118 to
0b79345
Compare
[build_iwasm ($CLASSIC_INTERP_BUILD_OPTIONS, -DWAMR_BUILD_LIB_PTHREAD=1, macos-latest, darwin)](https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/7220553955/job/19673804322)
GitHub Actions has encountered an internal error when running your job.I'm amending the commit to restart the job. |
eloparco
force-pushed
the
eloparco/set-log-level-embedder
branch
from
0b79345 to
2979b51
Compare
wenyongh
pushed a commit
that referenced
this pull request
Jan 24, 2024
Follow-up on #2907. The log level is needed in the host embedder to better integrate with the embedder's logger. Allow the developer to customize his bh_log callback with `cmake -DWAMR_BH_LOG=<log_callback>`, and update sample/basic to show the usage.
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Expose API `void wasm_runtime_set_log_level(log_level_t level)`.
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…#3070) Follow-up on bytecodealliance#2907. The log level is needed in the host embedder to better integrate with the embedder's logger. Allow the developer to customize his bh_log callback with `cmake -DWAMR_BH_LOG=<log_callback>`, and update sample/basic to show the usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.