Fix watchpoint segfault when using debug interpreter without server #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cimacmillan
force-pushed
the
cmmacmil/watchpoint_fix
branch
from
be45fb7 to
e8fc477
Compare
wenyongh
pushed a commit
to wenyongh/wasm-micro-runtime
that referenced
this pull request
Dec 14, 2022
|
@cimacmillan, @loganek The WAMR-1.1.2 was created: |
wenyongh
pushed a commit
that referenced
this pull request
Dec 19, 2022
wenyongh
pushed a commit
that referenced
this pull request
Dec 19, 2022
wenyongh
pushed a commit
that referenced
this pull request
Dec 20, 2022
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In a previous PR I had introduced memory watchpoint support. This adds two linked lists containing watchpoint locations that are checked on variable reads/writes. However, there is an edge-case where one could be using the
WASM_ENABLE_DEBUG_INTERP, but not within a debugging instance.In this, the interpreter attempts to read the debugging instance lists which are not initialised. This results in a segmentation fault in
bh_list_first_elemThis change checks whether the interpreter is running within a debugging instance. If not, it assigns the list pointers to null and
bh_list_first_elemhandles this gracefully