Update the top level CMakeLists.txt a bit #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following warning on macOS.
```
CMake Warning (dev):
Policy CMP0042 is not set: MACOSX_RPATH is enabled by default. Run "cmake
--help-policy CMP0042" for policy details. Use the cmake_policy command to set the policy and suppress this warning.
MACOSX_RPATH is not specified for the following targets:
iwasm_shared
This warning is for project developers. Use -Wno-dev to suppress it.
```
Disable -Wunused-parameter in the top level CMakeLists.txt as this repo has tons of it. Note: We have this particular warning disabled in build-scripts/runtime_lib.cmake too.
wenyongh
pushed a commit
that referenced
this pull request
Dec 6, 2022
Disable -Wunused-parameter in the top level CMakeLists.txt as this repo has tons of it. Note: We have this particular warning disabled in build-scripts/runtime_lib.cmake too. Bump minimum cmake version for the top level CMakeLists.txt to fix the following warning on macOS. ``` CMake Warning (dev): Policy CMP0042 is not set: MACOSX_RPATH is enabled by default. Run "cmake --help-policy CMP0042" for policy details. Use the cmake_policy command to set the policy and suppress this warning. MACOSX_RPATH is not specified for the following targets: iwasm_shared This warning is for project developers. Use -Wno-dev to suppress it. ```
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Disable -Wunused-parameter in the top level CMakeLists.txt as this repo has tons of it. Note: We have this particular warning disabled in build-scripts/runtime_lib.cmake too. Bump minimum cmake version for the top level CMakeLists.txt to fix the following warning on macOS. ``` CMake Warning (dev): Policy CMP0042 is not set: MACOSX_RPATH is enabled by default. Run "cmake --help-policy CMP0042" for policy details. Use the cmake_policy command to set the policy and suppress this warning. MACOSX_RPATH is not specified for the following targets: iwasm_shared This warning is for project developers. Use -Wno-dev to suppress it. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.