Make buffered printf to be a common feature #1483
Conversation
no1wudi
changed the title
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
core/config.h
Outdated
| /* Enable buffered printf for builtin libc or not */ | ||
| #ifndef BH_BUILTIN_LIBC_BUFFERED_PRINTF | ||
| #define BH_BUILTIN_LIBC_BUFFERED_PRINTF 0 | ||
| #define BH_BUILTIN_LIBC_BUFFERED_SIZE 128 | ||
| #define BH_BUILTIN_LIBC_BUFFERED_PREFIX | ||
| #endif |
There was a problem hiding this comment.
There are too many macros in config.h, these macro are only related to libc_builtin_wrapper.c, how about moving them to it?
| #if BH_BUILTIN_LIBC_BUFFERED_PRINTF != 0 | ||
| BH_BUILTIN_LIBC_BUFFERED_PREFIX static char | ||
| print_buf[BH_BUILTIN_LIBC_BUFFERED_SIZE] = { 0 }; | ||
| BH_BUILTIN_LIBC_BUFFERED_PREFIX static int print_buf_size = 0; |
There was a problem hiding this comment.
How about:
#ifndef BUILTIN_LIBC_BUFFERED_PRINTF
#define BUILTIN_LIBC_BUFFERED_PRINTF 0
#endif
#if BUILTIN_LIBC_BUFFERED_PRINTF != 0
#ifndef BUILTIN_LIBC_BUFFERED_PRINT_SIZE
#define BUILTIN_LIBC_BUFFERED_PRINT_SIZE 128
#endif
#ifndef BUILTIN_LIBC_BUFFERED_PRINT_PREFIX
#define BUILTIN_LIBC_BUFFERED_PRINT_PREFIX
#endif
BUILTIN_LIBC_BUFFERED_PRINT_PREFIX static char
print_buf[BUILTIN_LIBC_BUFFERED_PRINT_SIZE] = { 0 };
BUILTIN_LIBC_BUFFERED_PRINT_PREFIX static int print_buf_size = 0;
...| { | ||
| } |
There was a problem hiding this comment.
Should not change it, or CI code guideline will report error.
There was a problem hiding this comment.
Emm, it was changed by clang-format
|
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
| BH_BUILTIN_LIBC_BUFFERED_PREFIX static char | ||
| print_buf[BH_BUILTIN_LIBC_BUFFERED_SIZE] = { 0 }; | ||
| BH_BUILTIN_LIBC_BUFFERED_PREFIX static int print_buf_size = 0; |
There was a problem hiding this comment.
Should remove BUILTIN_LIBC_BUFFERED_PRINT_PREFIX and BUILTIN_LIBC_BUFFERED_PRINT_SIZE
| #define BH_BUILTIN_LIBC_BUFFERED_PRINTF 1 | ||
| #define BH_BUILTIN_LIBC_BUFFERED_SIZE 128 | ||
| #define BH_BUILTIN_LIBC_BUFFERED_PREFIX |
There was a problem hiding this comment.
Sure, forget to rename these symbols
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
…ce#1483) Add macros to control whether to use the libc-builtin buffered printf and the buffer size.
@wenyongh BTW, I can't find the origin definition of
BH_PLATFORM_OPENRTOS, do you know where it defined ?