Skip to content

sightglass-next: implement sightglass-server #93

@abrown

Description

@abrown

In order to report performance results based on PRs, we talked about implementing an HTTP server (e.g. in crates/server) that would:

  • listen for incoming POST requests that contain JSON with the PR URL, commit SHA, etc. necessary for doing a "master vs PR" comparison
  • to avoid DoS, verify that the request is an authorized one (not exactly sure how to do this but the GitHub action will need some form of token)
  • kick off some benchmark running, like sightglass-cli benchmark ... but we could call the same APIs from inside the web service
  • upon success, push a Markdown table of the significant performance differences as a comment to the GitHub PR (implies that sightglass-server has a GitHub token, like one from bytecodealliance-highfive)
  • upon failure, push the error message as a comment to the GitHub PR (implies that we maintain error logs somewhere)

There is a lot more to be done here but that should be a workable start.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions