Don't check the errno value from isatty.
#468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't actually do anything different for different errno values, other than panic on unknown ones, and that isn't that isn't adding much value compared to the cost of being an extra surprise when porting to new OS's. Fixes #467.
|
Any chance we could get a new release with this PR included? Thanks! |
sunfishcode
added a commit
that referenced
this pull request
Dec 5, 2022
We don't actually do anything different for different errno values, other than panic on unknown ones, and that isn't that isn't adding much value compared to the cost of being an extra surprise when porting to new OS's. Fixes #467.
sunfishcode
added a commit
that referenced
this pull request
Dec 5, 2022
We don't actually do anything different for different errno values, other than panic on unknown ones, and that isn't that isn't adding much value compared to the cost of being an extra surprise when porting to new OS's. Fixes #467.
|
This is now released in 0.36.5! |
|
Thanks @sunfishcode! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't actually do anything different for different errno values, other than panic on unknown ones, and that isn't that isn't adding much value compared to the cost of being an extra surprise when porting to new OS's.
Fixes #467.